feat: Sneaked vs snuck by hippietrail · Pull Request #2209 · Automattic/harper

hippietrail · 2025-11-17T10:30:23Z

Issues

N/A

Description

I reimplemented this based on the way I implemented the vicious circle vs vicious cycle linter.
In fact I asked an agent to do that. Sneaked vs snuck is simpler since it doesn't have to worry about a common spello like "viscious circle/cycle" in the other linter.

I simplified and refactored the code the agent produced a decent amount. But it's still worth giving code that agents were involved in closer scrutiny.

How Has This Been Tested?

There are some unit tests for lettercase variants and I picked two sentences from GitHub to use for real-world tests.

Checklist

I have performed a self-review of my own code
I have added tests to cover my changes

I feel the same. I initially was coding sneak/snuck a different way that didn't pan out but then realized that in the meantime the similar ViciousCircle/ViciousCycle module had been approved and merged so I rewrote 'snuck' based on a simplified version of the 'vicious' logic.

The difference is that 'vicious' has to deal with the common eggcorn 'viscous' at the same time as dealing with the preference for 'cycle' or 'circle'.

In the long run we'll see what strategy is adopted for mutually-exclusive rules and may come back and change these.

…aked-vs-snuck

into sneaked-vs-snuck

⚠️ **CAUTION: this is a major update, indicating a breaking change!** ⚠️ This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | major | `v1.12.0` → `v2.0.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v2.0.0`](https://github.com/Automattic/harper/releases/tag/v2.0.0) [Compare Source](Automattic/harper@v1.12.0...v2.0.0) #### What's Changed Hey all! We're finally releasing Harper 2.0. Why? It isn't because we have any new groundbreaking features in this release, because we don't let major versioning stop us from pushing those out as soon as they're ready. It's because we have some breaking changes. The biggest one only applies to you if you consume `harper.js`. From now on, instead of importing your binary from the main Harper module, you'll import it from one of four specialized modules. Previously, you'd import the Harper WebAssembly binary with: ```javascript import { LocalLinter, binary } from "harper.js"; ``` As of Harper 2.0, you'll import it like this: ```javascript import { LocalLinter } from "harper.js"; import { binary } from "harper.js/binary"; ``` It's that simple! Thanks to this change, you'll find that your applications are more conducive to tree-shaking and therefore might even be a bit smaller! In addition to that large breaking change, we also have a bunch of smaller improvements rolling out. I won't go through them one by one, but you're free to read through any of the linked pull requests below. - refactor(core): use `Option::get_or_insert_with` by [@86xsk](https://github.com/86xsk) in [#2977](Automattic/harper#2977) - test(linting): add comprehensive test cases for were/where lint rule by [@estefafdez](https://github.com/estefafdez) in [#2984](Automattic/harper#2984) - feat: means a lot for→means a lot to by [@hippietrail](https://github.com/hippietrail) in [#2982](Automattic/harper#2982) - feat: add subcommand to generate shell completions by [@deckstose](https://github.com/deckstose) in [#2978](Automattic/harper#2978) - refactor(core): extract indefinite article logic into its own module by [@mvanhorn](https://github.com/mvanhorn) in [#2980](Automattic/harper#2980) - feat(web): auto-detect dark theme from OS preference in [#2963](Automattic/harper#2963) - build(deps): bump tar from 0.4.44 to 0.4.45 by [@dependabot](https://github.com/dependabot)\[bot] in [#2986](Automattic/harper#2986) - feat: as evident by -> as evidenced by by [@mvanhorn](https://github.com/mvanhorn) in [#2985](Automattic/harper#2985) - fix(core): `SplitWords` allowing uncommon merges by [@elijah-potter](https://github.com/elijah-potter) in [#2874](Automattic/harper#2874) - feat: add lint rule for flaunt/flout mix-up in [#2962](Automattic/harper#2962) - test: add regression tests for need\_to\_noun false positives ([#2320](Automattic/harper#2320)) by [@majiayu000](https://github.com/majiayu000) in [#3014](Automattic/harper#3014) - fix: case-insensitive same-form check in SimplePastToPastParticiple by [@saschabuehrle](https://github.com/saschabuehrle) in [#3012](Automattic/harper#3012) - build(deps): bump pulldown-cmark from 0.13.1 to 0.13.3 by [@dependabot](https://github.com/dependabot)\[bot] in [#3002](Automattic/harper#3002) - build(deps): bump tree-sitter-rust from 0.24.0 to 0.24.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#3003](Automattic/harper#3003) - build(deps): bump zip from 8.1.0 to 8.3.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#3000](Automattic/harper#3000) - build(deps): bump cached from 0.56.0 to 0.59.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#3001](Automattic/harper#3001) - chore(harper.js): update `raw-web` example to `1.12.0` by [@elijah-potter](https://github.com/elijah-potter) in [#3015](Automattic/harper#3015) - feat: "a" & "an" both OK for "URL" by [@hippietrail](https://github.com/hippietrail) in [#2981](Automattic/harper#2981) - feat: except of→except for / exception of by [@hippietrail](https://github.com/hippietrail) in [#2997](Automattic/harper#2997) - build(deps): bump rustls-webpki from 0.103.8 to 0.103.10 by [@dependabot](https://github.com/dependabot)\[bot] in [#2991](Automattic/harper#2991) - feat: aspire for → aspire to by [@hippietrail](https://github.com/hippietrail) in [#3004](Automattic/harper#3004) - docs: added link to agent policy by [@elijah-potter](https://github.com/elijah-potter) in [#3016](Automattic/harper#3016) - fix(lint-framework): reconnect popup host after DOM replacement by [@k4sperski](https://github.com/k4sperski) in [#2998](Automattic/harper#2998) - fix(harper-cli): return exit code 0 when no lints are found by [@Ryujiyasu](https://github.com/Ryujiyasu) in [#2836](Automattic/harper#2836) - chore: dictionary curation 2026-03-19 by [@hippietrail](https://github.com/hippietrail) in [#2968](Automattic/harper#2968) - Added native Neovim LSP config to docs by [@RobertCrummett](https://github.com/RobertCrummett) in [#2987](Automattic/harper#2987) - fix: don't flag "more orange than red" etc. by [@hippietrail](https://github.com/hippietrail) in [#2928](Automattic/harper#2928) - perf(core): cache `WordSet` in `ModalVerb` by [@86xsk](https://github.com/86xsk) in [#3017](Automattic/harper#3017) - feat: flag "use to" when "used to" is intended in [#2975](Automattic/harper#2975) - feat: flag nonstandard "verse" used as a verb (from "versus") in [#2973](Automattic/harper#2973) - feat: flag "date back from" as blend of "date from" and "date back to" in [#2976](Automattic/harper#2976) - feat(core): allow users to include dictionaries in Weirpacks by [@elijah-potter](https://github.com/elijah-potter) in [#2922](Automattic/harper#2922) - feat: try out one's luck→try one's luck by [@hippietrail](https://github.com/hippietrail) in [#2916](Automattic/harper#2916) - fix(chrome-ext): reverse the toggle button to it appears "on" by [@elijah-potter](https://github.com/elijah-potter) in [#3026](Automattic/harper#3026) - chore: dictionary curation by [@hippietrail](https://github.com/hippietrail) in [#3023](Automattic/harper#3023) - Improve embedded form support in iframes by [@k4sperski](https://github.com/k4sperski) in [#3010](Automattic/harper#3010) - refactor: compact token/lint content & char comparison by [@hippietrail](https://github.com/hippietrail) in [#2957](Automattic/harper#2957) - feat: expression to match pronoun-be, word pair or contraction by [@hippietrail](https://github.com/hippietrail) in [#2944](Automattic/harper#2944) - fix(chrome-ext): persist lint rule changes from settings page by [@queelius](https://github.com/queelius) in [#3028](Automattic/harper#3028) - feat: in 1 day from now→in one day/one day from now by [@hippietrail](https://github.com/hippietrail) in [#3049](Automattic/harper#3049) - build(deps): bump tree-sitter-ink-lbz from 0.0.1 to 0.0.5 by [@dependabot](https://github.com/dependabot)\[bot] in [#3064](Automattic/harper#3064) - build(deps): bump ordered-float from 5.1.0 to 5.3.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#3063](Automattic/harper#3063) - build(deps): bump zip from 8.3.1 to 8.4.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#3065](Automattic/harper#3065) - feat: support Quarto qmd files as markdown by [@itamarst](https://github.com/itamarst) in [#3053](Automattic/harper#3053) - feat: thrive off (of)→thrive on by [@hippietrail](https://github.com/hippietrail) in [#3055](Automattic/harper#3055) - perf(core): optimizations in `LintGroup` by [@86xsk](https://github.com/86xsk) in [#3052](Automattic/harper#3052) - feat: worth while/worth-while → worthwhile by [@hippietrail](https://github.com/hippietrail) in [#3056](Automattic/harper#3056) - refactor(core)!: `Lrc<[char]>` instead of `Lrc<Vec<char>>` by [@86xsk](https://github.com/86xsk) in [#3060](Automattic/harper#3060) - chore: dictionary curation by [@hippietrail](https://github.com/hippietrail) in [#3041](Automattic/harper#3041) - build(deps): bump tree-sitter-rust from 0.24.1 to 0.24.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#3061](Automattic/harper#3061) - fix(obsidian): OOM error by reducing WASM bundle size by [@elijah-potter](https://github.com/elijah-potter) in [#3050](Automattic/harper#3050) - build(deps): bump tree-sitter-scala from 0.24.0 to 0.25.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#3062](Automattic/harper#3062) - fix(lint): add 'side' to ignore list for effect/affect rule (fix issue [#2958](Automattic/harper#2958)) by [@estefafdez](https://github.com/estefafdez) in [#2983](Automattic/harper#2983) - perf(spell): skip redundant lowercase DFA search in FstDictionary by [@k4sperski](https://github.com/k4sperski) in [#3025](Automattic/harper#3025) - refactor!: take argument by value instead of mut ref by [@86xsk](https://github.com/86xsk) in [#3051](Automattic/harper#3051) - feat: Sneaked vs snuck by [@hippietrail](https://github.com/hippietrail) in [#2209](Automattic/harper#2209) - feat: skeleton for new `ExprLinter` modules by [@hippietrail](https://github.com/hippietrail) in [#3024](Automattic/harper#3024) - feat: web scrapping → web scraping by [@hippietrail](https://github.com/hippietrail) in [#3059](Automattic/harper#3059) - fix: add key stroke→keystroke to key stoke→keystroke by [@hippietrail](https://github.com/hippietrail) in [#3067](Automattic/harper#3067) - perf(core): avoid conversion between string and char array by [@86xsk](https://github.com/86xsk) in [#3074](Automattic/harper#3074) - fix: don't flag "each of whom" by [@hippietrail](https://github.com/hippietrail) in [#3078](Automattic/harper#3078) - docs(web): add link to [@KraXen72](https://github.com/KraXen72)'s work by [@elijah-potter](https://github.com/elijah-potter) in [#3079](Automattic/harper#3079) - feat: at all cost → at all costs by [@hippietrail](https://github.com/hippietrail) in [#3082](Automattic/harper#3082) - fix(core): address recent false positives and negatives by [@elijah-potter](https://github.com/elijah-potter) in [#3090](Automattic/harper#3090) - feat: add styling for user-defined monospace fonts by [@stanley-910](https://github.com/stanley-910) in [#3105](Automattic/harper#3105) - feat: I am bias/you are prejudice→biased/prejudiced by [@hippietrail](https://github.com/hippietrail) in [#3058](Automattic/harper#3058) - fix: don't flag "to" before "only" in ToTwoToo by [@joaquinhuigomez](https://github.com/joaquinhuigomez) in [#3093](Automattic/harper#3093) - feat: ppl→people by [@hippietrail](https://github.com/hippietrail) in [#3116](Automattic/harper#3116) - feat/obsidian web lint styling by [@stanley-910](https://github.com/stanley-910) in [#3104](Automattic/harper#3104) - fix(lint-framework): preserve cursor position when dismissing suggestion popup by [@draphy](https://github.com/draphy) in [#3112](Automattic/harper#3112) - build(deps): bump uuid from 1.22.0 to 1.23.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#3117](Automattic/harper#3117) - fix: skip PronounVerbAgreement for hyphenated compounds by [@mvanhorn](https://github.com/mvanhorn) in [#3095](Automattic/harper#3095) - fix(harper-tex): mask additional LaTeX math environments by [@jurajkl](https://github.com/jurajkl) in [#3103](Automattic/harper#3103) - feat: look forward for→look forward to by [@hippietrail](https://github.com/hippietrail) in [#3109](Automattic/harper#3109) - build(deps): bump tempfile from 3.20.0 to 3.27.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#3118](Automattic/harper#3118) - build(deps): bump indexmap from 2.13.0 to 2.13.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#3121](Automattic/harper#3121) - build(deps): bump tracing-subscriber from 0.3.22 to 0.3.23 by [@dependabot](https://github.com/dependabot)\[bot] in [#3120](Automattic/harper#3120) - build(deps): bump zip from 8.4.0 to 8.5.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#3119](Automattic/harper#3119) - fix(core): exclude prepositions and conjunctions from QuiteQuiet pattern by [@draphy](https://github.com/draphy) in [#3127](Automattic/harper#3127) - feat: arrive to → arrive at/in by [@hippietrail](https://github.com/hippietrail) in [#3125](Automattic/harper#3125) - feat(core): create `UseEllipsisCharacter` rule by [@elijah-potter](https://github.com/elijah-potter) in [#3099](Automattic/harper#3099) - Fix indentation handling in harper-tex by [@jurajkl](https://github.com/jurajkl) in [#3106](Automattic/harper#3106) - feat: will ran → will run / ran by [@hippietrail](https://github.com/hippietrail) in [#2268](Automattic/harper#2268) - feat: in the best of times→at the best of times by [@hippietrail](https://github.com/hippietrail) in [#3133](Automattic/harper#3133) - feat: render configuration structurally by [@elijah-potter](https://github.com/elijah-potter) in [#3123](Automattic/harper#3123) - fix(chrome-ext): issues with Google Docs by [@elijah-potter](https://github.com/elijah-potter) in [#3141](Automattic/harper#3141) #### New Contributors - [@estefafdez](https://github.com/estefafdez) made their first contribution in [#2984](Automattic/harper#2984) - [@deckstose](https://github.com/deckstose) made their first contribution in [#2978](Automattic/harper#2978) - [@mvanhorn](https://github.com/mvanhorn) made their first contribution in [#2980](Automattic/harper#2980) - [@majiayu000](https://github.com/majiayu000) made their first contribution in [#3014](Automattic/harper#3014) - [@saschabuehrle](https://github.com/saschabuehrle) made their first contribution in [#3012](Automattic/harper#3012) - [@k4sperski](https://github.com/k4sperski) made their first contribution in [#2998](Automattic/harper#2998) - [@Ryujiyasu](https://github.com/Ryujiyasu) made their first contribution in [#2836](Automattic/harper#2836) - [@RobertCrummett](https://github.com/RobertCrummett) made their first contribution in [#2987](Automattic/harper#2987) - [@queelius](https://github.com/queelius) made their first contribution in [#3028](Automattic/harper#3028) - [@itamarst](https://github.com/itamarst) made their first contribution in [#3053](Automattic/harper#3053) - [@joaquinhuigomez](https://github.com/joaquinhuigomez) made their first contribution in [#3093](Automattic/harper#3093) - [@jurajkl](https://github.com/jurajkl) made their first contribution in [#3103](Automattic/harper#3103) **Full Changelog**: <Automattic/harper@v1.12.0...v2.0.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

hippietrail added 9 commits November 17, 2025 17:21

feat: work in progress: "sneaked" vs "snuck"

c2753ba

fix: fmt

6e6ce94

Merge branch 'master' into sneaked-vs-snuck

5173e96

fix: avoid infinite loops between the two sub-linters

f4e4dfa

Merge branch 'sneaked-vs-snuck' of https://github.com/hippietrail/harper

d4f3640

into sneaked-vs-snuck

fix: format typescript

7916e85

fix: formatting is very picky!

f3df73d

Merge branch 'master' of https://github.com/Automattic/harper into sn…

a323919

…eaked-vs-snuck

chore: merge upstream

c9488c0

This was referenced Dec 30, 2025

feat: vicious circle vs cycle #2384

Merged

Need support for mutually exclusive / multi-way settings #2396

Open

hippietrail added 7 commits January 12, 2026 22:49

Merge branch 'master' of https://github.com/Automattic/harper into sn…

708e9f1

…eaked-vs-snuck

Merge branch 'master' into sneaked-vs-snuck

2ced8f9

Merge branch 'master' into sneaked-vs-snuck

79a4479

Merge branch 'master' of https://github.com/Automattic/harper into sn…

de90e0f

…eaked-vs-snuck

Merge branch 'sneaked-vs-snuck' of https://github.com/hippietrail/harper

c7d5b82

into sneaked-vs-snuck

Merge branch 'master' of http://github.com/Automattic/harper into sne…

dde3f5e

…aked-vs-snuck

refactor: simplified from vicious circle/cycle

00f6fcc

hippietrail marked this pull request as ready for review March 11, 2026 05:22

hippietrail changed the title ~~work in progress: Sneaked vs snuck~~ fead: Sneaked vs snuck Mar 11, 2026

hippietrail added 5 commits March 11, 2026 12:35

test: unit tests for each that don't need fixing

0171d0f

Merge branch 'master' into sneaked-vs-snuck

e76be3e

Merge branch 'master' of http://github.com/Automattic/harper into sne…

f6c9f89

…aked-vs-snuck

Merge branch 'sneaked-vs-snuck' of https://github.com/hippietrail/harper

67cd146

into sneaked-vs-snuck

Merge branch 'master' into sneaked-vs-snuck

e2b290d

hippietrail requested a review from elijah-potter March 17, 2026 03:18

hippietrail added 4 commits March 19, 2026 10:46

Merge branch 'master' into sneaked-vs-snuck

5251e0c

Merge branch 'master' into sneaked-vs-snuck

63aee66

Merge branch 'master' into sneaked-vs-snuck

a9d9881

Merge branch 'master' into sneaked-vs-snuck

e675df9

hippietrail changed the title ~~fead: Sneaked vs snuck~~ feat: Sneaked vs snuck Mar 24, 2026

elijah-potter previously approved these changes Mar 25, 2026

View reviewed changes

elijah-potter added this pull request to the merge queue Mar 25, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 25, 2026

elijah-potter added 2 commits March 25, 2026 12:21

Merge branch 'master' into sneaked-vs-snuck

6c8c9f9

fix(core): update to new extension methods

5949937

elijah-potter dismissed their stale review via 5949937 March 25, 2026 18:25

elijah-potter enabled auto-merge March 25, 2026 18:25

elijah-potter added this pull request to the merge queue Mar 25, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 25, 2026

elijah-potter and others added 5 commits March 25, 2026 13:22

Merge branch 'master' into sneaked-vs-snuck

f77c3a0

Merge branch 'master' of http://github.com/Automattic/harper into sne…

803295c

…aked-vs-snuck

chore: merge w/ upstream

fe37281

Merge branch 'sneaked-vs-snuck' of https://github.com/hippietrail/harper

e0a8629

into sneaked-vs-snuck

Merge branch 'master' into sneaked-vs-snuck

d9ed019

elijah-potter added this pull request to the merge queue Mar 31, 2026

Merged via the queue into Automattic:master with commit 9876560 Mar 31, 2026
11 checks passed

hippietrail deleted the sneaked-vs-snuck branch March 31, 2026 18:24

BrewTestBot mentioned this pull request Apr 8, 2026

harper 2.0.0 Homebrew/homebrew-core#276738

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Sneaked vs snuck#2209

feat: Sneaked vs snuck#2209
elijah-potter merged 32 commits intoAutomattic:masterfrom
hippietrail:sneaked-vs-snuck

hippietrail commented Nov 17, 2025 •

edited

Loading

Uh oh!

elijah-potter left a comment

Uh oh!

elijah-potter Mar 25, 2026

Uh oh!

hippietrail Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

+                  })
+              }
+              macro_rules! impl_expr_linter {

Conversation

hippietrail commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Description

How Has This Been Tested?

Checklist

See Also

Uh oh!

elijah-potter left a comment

Choose a reason for hiding this comment

Uh oh!

elijah-potter Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

hippietrail Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hippietrail commented Nov 17, 2025 •

edited

Loading