Boost: Fix JITM rendering above header on cache debug log page#47699
Boost: Fix JITM rendering above header on cache debug log page#47699
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Search plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Social plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Starter Plugin plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Super Cache plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Inspect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Automattic For agencies client plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Classic Theme helper plugin plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Paypal Payment buttons plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
4102257 to
6d5865a
Compare
Add #jp-admin-notices container inside jb-dashboard > jb-container on the cache debug log page so JITMs render below the header instead of above it. Follows the same pattern as the main Boost page and the JITM fixes in #47558. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The JITM container was in a standalone jb-container outside any jb-section wrapper, creating a white background strip and visible separator line between the JITM and the page content. Move it inside the existing jb-section--main container to match the main Boost page pattern where the JITM sits inside a styled section. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Proposed changes
#jp-admin-noticesJITM slot to the Boost cache debug log page, insidejb-dashboard > jb-container, matching the same structure used on the main Boost page (speed-score.tsx).#wpbody-content) instead of below it.Other information
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Setup: Fake JITM
Add the following snippet to a mu-plugin (e.g.
wp-content/mu-plugins/fake-jitm.php) — see #47558 for the full snippet.Test
wp-admin/admin.php?page=jetpack-boost)#/cache-debug-log)