Fix module name casing in module list#47843
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
There was a problem hiding this comment.
Pull request overview
Updates Jetpack module display names to use consistent Title Case in the modules list (and related REST response), aligning the UI labels across modules.
Changes:
- Adjust module header
Module Namevalues to consistent casing across several modules. - Update the REST API authentication test expectation for the Protect module name.
- Add a Jetpack changelogger entry describing the UI label normalization.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| projects/plugins/jetpack/tests/php/_inc/lib/Jetpack_REST_API_Authentication_Test.php | Updates expected module name in REST response to match new Protect module label casing. |
| projects/plugins/jetpack/modules/verification-tools.php | Title-cases module display name (“Site Verification”). |
| projects/plugins/jetpack/modules/related-posts.php | Title-cases module display name (“Related Posts”). |
| projects/plugins/jetpack/modules/protect.php | Title-cases module display name (“Brute Force Protection”). |
| projects/plugins/jetpack/modules/post-by-email.php | Title-cases module display name (“Post by Email”). |
| projects/plugins/jetpack/modules/custom-content-types.php | Title-cases module display name (“Custom Content Types”). |
| projects/plugins/jetpack/modules/account-protection.php | Title-cases module display name (“Account Protection”). |
| projects/plugins/jetpack/changelog/fix-module-name-casing | Adds changelog entry for the module list capitalization change. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
I think we'd wanna do the opposite, as our copy style is Sentence case, not Title Case (internal ref PCYsg-5n-p2 ). That said, we're about to remove links to this page in next Jetpack version, and then eventually the whole page, so I don't know if this really matters much to spend time on this. :-) |
Fixes MONOREP-401
Proposed changes
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Before:
After: