perf(criteria): filter-out older views before sorting articles read in session#1172
Draft
miguelpeixe wants to merge 7 commits into
Draft
perf(criteria): filter-out older views before sorting articles read in session#1172miguelpeixe wants to merge 7 commits into
miguelpeixe wants to merge 7 commits into
Conversation
* chore: remove Lightweight API and client ID handling * chore: remove data pruning cron job and clear future instances * fix: script dependencies * fix: remove unused method refs * test: remove tests using deprecated features * chore: remove more unneeded files * test: remove other failing tests
Co-authored-by: Leo Germani <leogermani@automattic.com>
Contributor
|
@miguelpeixe can we close this one? |
Member
Author
|
Thanks for reminding me @dkoo! This is actually still a relevant, but not urgent, performance tweak to the "articles read" matching function. We don't need this for the epic release, I'll make this PR available for review later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Set a 6 hours threshold to filter out views before sorting and calculating the articles read in session. Even though a session can stretch for several hours if the reader keeps reading articles, it's not likely to get longer than 6 hours.
Currently, the sorting will run over every article read in the store history, which is not necessary and can have some performance impact.
How to test the changes in this Pull Request:
Other information: