Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5693 +/- ##
=============================================
- Coverage 33.36% 33.19% -0.17%
- Complexity 4938 4956 +18
=============================================
Files 291 294 +3
Lines 20953 21060 +107
=============================================
Hits 6990 6990
- Misses 13963 14070 +107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| add_filter( 'qm/output/menu_class', array( $this, 'admin_class' ) ); | ||
| add_filter( 'qm/output/menus', array( $this, 'admin_menu' ), 101 ); |
There was a problem hiding this comment.
Is it possible to not display the panel altogether if there's no data (i.e. $data->logs is empty)?
|
|
This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed. This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved. |
|
This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed. This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved. |
|
This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed. This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved. |
Co-authored-by: Rinat K <rinat@automattic.com>
238171a to
b0817b5
Compare
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Query Monitor panel specifically for displaying debugging information about VIP's JavaScript and CSS concatenation feature. The panel provides visibility into concatenation processes and potential issues.
Key Changes:
- Add new QM plugin structure for VIP concatenation monitoring
- Create collector and output classes to handle concat-specific logging
- Integrate the new panel into the existing Query Monitor framework
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| query-monitor.php | Adds conditional require for the new VIP concat QM plugin |
| qm-plugins/qm-vip-concat/readme.md | Creates basic README for the new QM plugin |
| qm-plugins/qm-vip-concat/qm-vip-concat.php | Main plugin file that registers collector and output components |
| qm-plugins/qm-vip-concat/class-qm-output-vip-concat.php | Output class for rendering the concat panel UI and data tables |
| qm-plugins/qm-vip-concat/class-qm-collector-vip-concat.php | Collector class for gathering concat-related log data |
Comments suppressed due to low confidence (2)
qm-plugins/qm-vip-concat/qm-vip-concat.php:22
- The word 'explicity' should be spelled 'explicitly'.
* installed so we don't have to explicity check for it.
| <?php | ||
| /** | ||
| * Plugin Name: Query Monitor: VIP Concat | ||
| * Description: |
There was a problem hiding this comment.
The Description field in the plugin header is empty. It should contain a brief description of what the plugin does, such as 'Adds Query Monitor panel for VIP JS/CSS concatenation debugging.'
| * Description: | |
| * Description: Adds Query Monitor panel for VIP JS/CSS concatenation debugging. |
|
I'm going to close it because I'm not sure if it's compatible with QM4 without changes. |
Description
Adds a QM panel for displaying debugging information about VIP's JS/CSS concatenation feature.
Will not display any information without Automattic/nginx-http-concat#77
Changelog Description
Add "VIP JS/CSS Concat" Query Monitor Panel
Added
Removed
Fixed
Changed
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test