Guard fclose() against false stream in supercache-only mode#1053
Merged
Conversation
In supercache-only mode $fr is false (the wp-cache file is never opened). When the supercache temp file fails to open, the error branches called @fclose( $fr ) = @fclose( false ). On PHP 8+ that is a TypeError, which @ does not suppress, so the request fatals. Only call fclose() when the stream is open. Fixes #1016.
phpcs-changed flags the now-modified fclose() lines under WordPress.WP.AlternativeFunctions; match the file's existing inline-ignore convention for direct filesystem calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1016.
In supercache-only mode
$frisfalse(the wp-cache file is never opened). When the supercache temp file fails to open, the error branches inwp_cache_get_ob()called@fclose( $fr )— i.e.@fclose( false ). On PHP 8+ that is aTypeError, which@does not suppress, so the request fatals (matches the report'sfclose(): Argument #1 ($stream) must be of type resource, false given).Fix: only call
fclose()when the stream is actually open. Two call sites guarded; the adjacentfclose( $fr2 )is left as-is because$fr2is a valid resource on that branch.Note: PR #1042 also contains this fix (bundled with the #1019
$blog_idcast and two redundant guards). This PR isolates just the #1016 fix.