Cast $blog_id to int in wp_cache_clear_cache()#1054
Merged
Conversation
Third-party callers sometimes pass a non-integer (e.g. wp_cache_clear_cache('all', false)). The value flows to get_supercache_dir() -> get_blog_option(), a multisite-only function, fataling on single-site installs. Casting to int normalizes 'all'/false to 0, taking the single-site clearing path.
Fixes #1019.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1019.
Some third-party callers invoke
wp_cache_clear_cache()with a non-integer first argument (e.g.wp_cache_clear_cache('all', false)). That value flows intoget_supercache_dir()->get_blog_option(), a multisite-only function, which fatals on single-site installs.Casting
$blog_idtointnormalizes'all'/falseto0, so those calls take the single-site clearing path. Legitimate integer blog IDs are unaffected.Note: PR #1042 also contains this cast (bundled with the #1016
fclosefix and two redundant guards). This PR isolates just the #1019 fix.