Skip to content

feat: operation name support#1634

Merged
bjnewman merged 2 commits into
masterfrom
feature/thanos-operation-name
Oct 21, 2025
Merged

feat: operation name support#1634
bjnewman merged 2 commits into
masterfrom
feature/thanos-operation-name

Conversation

@bjnewman
Copy link
Copy Markdown
Contributor

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  5. Make sure your code passed the conventional commits check. Read more about conventional commits

Copy link
Copy Markdown
Contributor

@gregmartDOTin gregmartDOTin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to push a fix to the deploy job. Please do not merge yet.

@bjnewman
Copy link
Copy Markdown
Contributor Author

@gregmartDOTin please let me know when we are unblocked

Comment thread packages/spaces/src/Spaces.js
@gregmartDOTin
Copy link
Copy Markdown
Contributor

@gregmartDOTin please let me know when we are unblocked

This is now unblocked, but I did have a note on the logic.

Copy link
Copy Markdown
Contributor

@gregmartDOTin gregmartDOTin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bjnewman!

@bjnewman bjnewman merged commit d276702 into master Oct 21, 2025
13 of 14 checks passed
@bjnewman bjnewman deleted the feature/thanos-operation-name branch October 21, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants