fix: consolidate onlyBuiltDependencies into pnpm-workspace.yaml - #397
Merged
Conversation
package.json's pnpm.onlyBuiltDependencies:[better-sqlite3] overrode (didn't merge with) the workspace list, so electron, electron-winstaller, esbuild, lefthook, and unrs-resolver were silently skipped at install; move better-sqlite3 into the workspace list and drop the package.json block so one authoritative list allows all six. pnpm ignored-builds now reports only onnxruntime-node/protobufjs/sharp (which Electron rebuilds separately). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pnpm build allowlist for ChangesBuild Allowlist Configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.json's pnpm.onlyBuiltDependencies:[better-sqlite3] overrode (didn't merge with) the workspace list, so electron, electron-winstaller, esbuild, lefthook, and unrs-resolver were silently skipped at install; move better-sqlite3 into the workspace list and drop the package.json block so one authoritative list allows all six. pnpm ignored-builds now reports only onnxruntime-node/protobufjs/sharp (which Electron rebuilds separately).
Summary by CodeRabbit