Skip to content

fix: consolidate onlyBuiltDependencies into pnpm-workspace.yaml - #397

Merged
failerko merged 1 commit into
mainfrom
fix/pnpm-onlybuilt-deps
Jul 24, 2026
Merged

fix: consolidate onlyBuiltDependencies into pnpm-workspace.yaml#397
failerko merged 1 commit into
mainfrom
fix/pnpm-onlybuilt-deps

Conversation

@failerko

@failerko failerko commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

package.json's pnpm.onlyBuiltDependencies:[better-sqlite3] overrode (didn't merge with) the workspace list, so electron, electron-winstaller, esbuild, lefthook, and unrs-resolver were silently skipped at install; move better-sqlite3 into the workspace list and drop the package.json block so one authoritative list allows all six. pnpm ignored-builds now reports only onnxruntime-node/protobufjs/sharp (which Electron rebuilds separately).

Summary by CodeRabbit

  • Chores
    • Updated package installation settings to consistently allow the required native database component to build.
    • Simplified package manager configuration while preserving the existing workspace setup.

package.json's pnpm.onlyBuiltDependencies:[better-sqlite3] overrode (didn't merge with) the workspace list, so electron, electron-winstaller, esbuild, lefthook, and unrs-resolver were silently skipped at install; move better-sqlite3 into the workspace list and drop the package.json block so one authoritative list allows all six. pnpm ignored-builds now reports only onnxruntime-node/protobufjs/sharp (which Electron rebuilds separately).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a72faf56-66e8-46be-af66-e31ac4181c81

📥 Commits

Reviewing files that changed from the base of the PR and between 9a4cb4d and f858eb2.

📒 Files selected for processing (2)
  • package.json
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

The pnpm build allowlist for better-sqlite3 is moved from package.json to pnpm-workspace.yaml.

Changes

Build Allowlist Configuration

Layer / File(s) Summary
Relocate better-sqlite3 build configuration
package.json, pnpm-workspace.yaml
Removes the nested manifest pnpm configuration and adds better-sqlite3 to the workspace onlyBuiltDependencies allowlist.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a bunny with a build to hop,
better-sqlite3 now reaches the top.
From package nest to workspace wide,
The allowlist finds a clearer stride.
Hop, hop—let dependencies compile!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: moving onlyBuiltDependencies into pnpm-workspace.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@failerko
failerko merged commit e488866 into main Jul 24, 2026
4 checks passed
@failerko
failerko deleted the fix/pnpm-onlybuilt-deps branch July 24, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant