Slice/m3.1b embedder lifecycle

[failerko]

Summary by CodeRabbit

• New Features
  • Added a Memory panel in Story Settings with stale-status visibility, reindex/model swap/relabel actions, and inline resume for pending swaps.
  • Introduced embedder swap and swap-resume dialogs, plus provider-based embedding-dimension detection to support effective-dimension memory-cost configuration.
  • Enabled automatic background processing to drain incomplete embeddings.
• Bug Fixes
  • Improved generation status pill errors (including memory-incomplete and swap-paused) with updated actions/tap behavior.
  • Added stricter validation and clearer messaging for invalid custom effective dimensions.
• Tests
  • Expanded UI, unit, and end-to-end coverage across memory, embedding drain, swap/resume, and wizard flows.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 59934011-32f3-4b84-8c9a-2f9475ca9609

📥 Commits

Reviewing files that changed from the base of the PR and between 7cf2142 and b0066a3.

⛔ Files ignored due to path filters (1)

• docs/implementation/milestones/03-memory-floor/slices/01b-embedder-lifecycle.md is excluded by !docs/**

📒 Files selected for processing (19)

• components/embedder/swap-resume-host.tsx
• components/story-settings/memory-panel.tsx
• components/wizard/finish.test.ts
• components/wizard/finish.ts
• components/wizard/memory-cost-disclosure.stories.tsx
• components/wizard/memory-cost-disclosure.tsx
• components/wizard/memory-cost-logic.test.ts
• components/wizard/memory-cost-logic.ts
• hooks/use-swap-resume-actions.ts
• lib/actions/embedder-swap/app-deps.test.ts
• lib/actions/embedder-swap/index.ts
• lib/actions/index.ts
• lib/actions/settings/providers.test.ts
• lib/actions/settings/providers.ts
• lib/db/stories/settings-ops.test.ts
• lib/db/stories/settings-ops.ts
• lib/embedder/drain.test.ts
• lib/embedder/drain.ts
• locales/en/wizard.json

🚧 Files skipped from review as they are similar to previous changes (10)

• lib/actions/embedder-swap/index.ts
• lib/db/stories/settings-ops.ts
• components/wizard/memory-cost-disclosure.tsx
• lib/embedder/drain.ts
• locales/en/wizard.json
• lib/db/stories/settings-ops.test.ts
• components/wizard/finish.test.ts
• lib/embedder/drain.test.ts
• lib/actions/embedder-swap/app-deps.test.ts
• components/wizard/finish.ts

---

📝 Walkthrough

Walkthrough

This PR adds provider embedding-dimension discovery, Matryoshka configuration, model swap and relabel workflows, stale-row draining, memory settings UI, resume prompts, status reporting, database indexes, and extensive unit, Storybook, and end-to-end coverage.

Changes

Embedding configuration and wizard

Layer / File(s)	Summary
Effective-dimension selection and commit flow components/wizard/*, app/wizard.tsx, lib/stores/wizard/*, lib/db/stories/*	The wizard exposes validated effective-dimension choices, persists touched selections, validates invalid drafts, and commits effective dimensions for applicable provider models.
Provider probing and truncation lib/actions/settings/*, lib/ai/*, lib/embedder/*	Provider dimensions are probed and cached, provider configs carry truncation metadata, and embedding requests and vectors honor server- or client-side effective dimensions.

Embedding storage and swap workflows

Layer / File(s)	Summary
Vector and stale-row storage lib/db/embeddings/*, lib/db/runtime/*, lib/db/*table.ts, lib/db/migrations/*	Vector identities include model IDs, stale-row queries and recomputation become set-based, and partial stale indexes plus migration metadata are added.
Swap engine and drain orchestration lib/actions/embedder-swap/*, lib/embedder/drain.ts, lib/boot/bootstrap.ts	Swap staging, resume, cancellation, relabeling, crash recovery, per-story locking, and idle stale-row draining are implemented with progress and retry handling.

Application UI and validation

Layer / File(s)	Summary
Memory and swap UI components/story-settings/*, components/embedder/*, app/story-settings/*, app/reader-composer/*, lib/stores/ui/*, locales/en/*	Story settings expose memory status, reindex, swap, relabel, cancel, and resume controls; the generation pill reports memory-incomplete and swap-paused states.
Integration coverage and runtime wiring app/_layout.tsx, e2e/*, components/**/*.stories.tsx, lib/**/*.test.ts	Root hosts, Storybook interactions, unit tests, and Playwright scenarios validate provider probing, memory states, drain behavior, swaps, relabeling, and resume flows.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

• AventurasTeam/Aventuras#363 — overlaps the reader generation-status pill integration.
• AventurasTeam/Aventuras#365 — overlaps the wizard finish flow and effective-dimension validation.

Poem

I’m a bunny with vectors, hopping in line,
Swapping old memories for models divine.
Stale rows get drained, dimensions grow,
Resume or cancel—now buttons say so.
Tests nibble carrots and status lights glow!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 29.37% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the PR’s main theme: embedder lifecycle work, and is concise enough for history scanning.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 7

🧹 Nitpick comments (6)

lib/db/runtime/exec.native.ts (1)

20-31: 🚀 Performance & Scalability | 🔵 Trivial | 🏗️ Heavy lift

Avoid synchronous, unbounded native row loading.

queryRows is declared async but calls getAllSync and materializes every result row. The swap workflow uses it to load stale rows for each vector kind, so large stories can block the JS thread and allocate the full result before batching begins. Prefer an async or chunked query path while preserving the positional-row contract.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/db/runtime/exec.native.ts` around lines 20 - 31, Update queryRows to
avoid getAllSync and unbounded full-result materialization by using the
available asynchronous or chunked expo-sqlite query mechanism. Preserve its
Promise-based API and positional-row contract by converting each fetched row
with Object.values() in SELECT column order, while allowing callers to process
stale rows incrementally.

lib/db/stories/settings-ops.ts (1)

73-75: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Missing test coverage for setSwapTargetDimOp.

Every other exported op in this file has a dedicated test; this one is exercised nowhere in settings-ops.test.ts.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/db/stories/settings-ops.ts` around lines 73 - 75, Add a dedicated test
for the exported setSwapTargetDimOp function in settings-ops.test.ts, verifying
it produces the expected settings patch for embedding_swap_target_dim and
preserves the provided storyId and nowMs values, consistent with the other
settings operation tests.

locales/en/wizard.json (1)

53-57: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider parameterizing the chapter-count assumption.

30 is baked into both storagePreview and footer. Passing it as {{chapters}} keeps copy in sync with the estimation constant and avoids the untranslatable ch abbreviation.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@locales/en/wizard.json` around lines 53 - 57, Update the storagePreview and
footer locale strings to replace the hardcoded 30 chapter count with the
{{chapters}} interpolation, and replace the abbreviated “ch” with translatable
wording. Ensure the corresponding storage-estimate rendering passes the
estimation constant as chapters so both messages remain synchronized.

lib/actions/embedder-swap/index.ts (1)

1-31: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Barrel omits SwapMarkerChangedError and the SwapCancelOutcome type.

cancelStorySwap returns SwapCancelOutcome, so consumers outside this folder can't name its result type, and SwapMarkerChangedError (thrown by the phase-2 preflight) can't be caught by type through the public surface while every sibling swap error can.

♻️ Suggested export additions

   SwapNotInProgressError,
+  SwapMarkerChangedError,
   SwapStoryMissingError,

   startStorySwap,
   SwapBusyError,
   SwapConfigError,
+  type SwapCancelOutcome,
 } from './app-deps'

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/actions/embedder-swap/index.ts` around lines 1 - 31, Add
SwapMarkerChangedError and the SwapCancelOutcome type to the public exports in
lib/actions/embedder-swap/index.ts, sourcing each from the module that defines
it alongside the existing swap errors and related types. Preserve all current
exports so consumers can name cancelStorySwap’s return type and catch the
phase-2 preflight error through the barrel.

lib/actions/index.ts (1)

2-29: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider not re-exporting raw engine primitives from the app-wide actions barrel.

startSwap, resumeSwap, reindexStory, cancelSwap, relabelModel and SwapDeps/SwapParams require the caller to hold the per-story single-flight lock (engine.ts header contract); the safe entry points are the *Story* wrappers that go through runExclusive. Exposing both side by side at lib/actions makes the unsafe pair the more obvious import and orphaned staged vectors the failure mode. Keeping the primitives reachable only via @/lib/actions/embedder-swap (tests) would narrow that surface.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/actions/index.ts` around lines 2 - 29, Remove the raw engine primitives
startSwap, resumeSwap, reindexStory, cancelSwap, relabelModel, and the
SwapDeps/SwapParams types from the lib/actions barrel export. Keep the *Story*
wrapper entry points and error/configuration exports available, leaving
primitives reachable only through the embedder-swap module.

components/story-settings/memory-panel.tsx (1)

1-1: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Extract shared resume/cancel-swap error-handling into one hook.

MemoryPanel and SwapResumeHost each reimplement the same resume/cancel-swap orchestration (SwapBusyError→toast.info branch, logger.error with the same key shape, generic toast.error, and finally(() => void refreshEmbeddingStatus(storyId))), differing only in whether a dialog is closed/navigated first. A shared useSwapResumeActions(storyId) (or similar) hook would remove the duplication and keep the error-reporting contract in one place as it evolves.

• components/story-settings/memory-panel.tsx#L150-277: extract reportEngineFailure, handleResume, and handleCancelSwap into the shared hook, keeping only the swap-dialog-close call local to this component.
• components/embedder/swap-resume-host.tsx#L46-83: extract report, onResume, and onCancelSwap into the same shared hook, keeping only the router.navigate call local to this component.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@components/story-settings/memory-panel.tsx` at line 1, Extract the duplicated
resume/cancel-swap orchestration from MemoryPanel’s reportEngineFailure,
handleResume, and handleCancelSwap and SwapResumeHost’s report, onResume, and
onCancelSwap into a shared useSwapResumeActions(storyId) hook. Preserve the
SwapBusyError toast.info path, logger.error key shape, generic toast.error
handling, and finally refreshEmbeddingStatus(storyId); keep only MemoryPanel’s
dialog-close call and SwapResumeHost’s router.navigate call local.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@components/compounds/embedder-default-card.tsx`:
- Around line 140-174: The persistProvider flow must prevent stale asynchronous
probe results from writing dimensions after a newer selection is made. Add a
selection-generation or equivalent current-selection check around
ensureProviderEmbeddingDim and its recordProviderEmbeddingDim persistence, and
only allow the probe result to write when it still matches the latest
provider/model selection and pending defaults; preserve the existing save and
warning behavior for current selections.

In `@components/wizard/finish.ts`:
- Around line 64-84: Validate the selected dimension against the current model’s
supported ceiling before committing: update the finish flow around effectiveDim
and the dimension validation in components/wizard/memory-cost-logic.ts (lines
42-51) to reject values above embeddingCapabilities.embeddingDim or the intended
valid ladder value, while preserving native/null behavior for non-applicable
models. Thread the dimension bounds through validateCustomDim or its caller so
stale working-state selections cannot commit oversized dimensions.

In `@lib/actions/embedder-swap/app-deps.test.ts`:
- Around line 662-675: Update the assertion following cancelStorySwap in the
cancellation test to inspect the current cancelSwap invocation via
mock.lastCall?.[1], or reset the mock call history before the test. Preserve the
existing expected swap fields while removing reliance on calls[0] and prior test
execution order.

In `@lib/actions/settings/providers.ts`:
- Around line 57-85: Serialize the read-modify-persist operation in
recordProviderEmbeddingDim with a promise-chain lock keyed by providerId,
ensuring concurrent updates for different models on the same provider execute
sequentially and each reads the latest cachedModels state before updateProvider
persists it. Preserve the existing validation and provider-not-found behavior.

In `@lib/db/stories/settings-ops.test.ts`:
- Around line 194-198: Update the titles of both tests around
setEmbeddingTargetOp to reference setEmbeddingTargetOp instead of the removed
setEmbeddingModelIdOp, while leaving their test logic unchanged.

In `@lib/db/stories/settings-ops.ts`:
- Around line 26-30: Update embeddingTargetKey to encode each providerId and
modelId component with an unambiguous delimiter-safe representation before
composing the key, so values containing colons cannot collide. Preserve the
provider/local prefixes and ensure distinct target components always produce
distinct stable keys.

In `@lib/embedder/drain.ts`:
- Around line 41-44: Update the scheduling logic in schedule and noteIdle so
idle notifications do not clear or replace an already-armed retry timer from the
backoff ladder; preserve the pending retry until it fires. Keep kick’s explicit
recovery behavior unchanged so it can still override the existing timer and
trigger an immediate drain.

---

Nitpick comments:
In `@components/story-settings/memory-panel.tsx`:
- Line 1: Extract the duplicated resume/cancel-swap orchestration from
MemoryPanel’s reportEngineFailure, handleResume, and handleCancelSwap and
SwapResumeHost’s report, onResume, and onCancelSwap into a shared
useSwapResumeActions(storyId) hook. Preserve the SwapBusyError toast.info path,
logger.error key shape, generic toast.error handling, and finally
refreshEmbeddingStatus(storyId); keep only MemoryPanel’s dialog-close call and
SwapResumeHost’s router.navigate call local.

In `@lib/actions/embedder-swap/index.ts`:
- Around line 1-31: Add SwapMarkerChangedError and the SwapCancelOutcome type to
the public exports in lib/actions/embedder-swap/index.ts, sourcing each from the
module that defines it alongside the existing swap errors and related types.
Preserve all current exports so consumers can name cancelStorySwap’s return type
and catch the phase-2 preflight error through the barrel.

In `@lib/actions/index.ts`:
- Around line 2-29: Remove the raw engine primitives startSwap, resumeSwap,
reindexStory, cancelSwap, relabelModel, and the SwapDeps/SwapParams types from
the lib/actions barrel export. Keep the *Story* wrapper entry points and
error/configuration exports available, leaving primitives reachable only through
the embedder-swap module.

In `@lib/db/runtime/exec.native.ts`:
- Around line 20-31: Update queryRows to avoid getAllSync and unbounded
full-result materialization by using the available asynchronous or chunked
expo-sqlite query mechanism. Preserve its Promise-based API and positional-row
contract by converting each fetched row with Object.values() in SELECT column
order, while allowing callers to process stale rows incrementally.

In `@lib/db/stories/settings-ops.ts`:
- Around line 73-75: Add a dedicated test for the exported setSwapTargetDimOp
function in settings-ops.test.ts, verifying it produces the expected settings
patch for embedding_swap_target_dim and preserves the provided storyId and nowMs
values, consistent with the other settings operation tests.

In `@locales/en/wizard.json`:
- Around line 53-57: Update the storagePreview and footer locale strings to
replace the hardcoded 30 chapter count with the {{chapters}} interpolation, and
replace the abbreviated “ch” with translatable wording. Ensure the corresponding
storage-estimate rendering passes the estimation constant as chapters so both
messages remain synchronized.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 607ad4a5-043a-43ec-bd6e-1a0a3c517f1e

📥 Commits

Reviewing files that changed from the base of the PR and between e488866 and 7cf2142.

⛔ Files ignored due to path filters (9)

• docs/data-model.md is excluded by !docs/**
• docs/implementation/milestones/03-memory-floor/slices/01b-embedder-lifecycle.md is excluded by !docs/**
• docs/implementation/milestones/03-memory-floor/slices/04-retrieval.md is excluded by !docs/**
• docs/implementation/triage.md is excluded by !docs/**
• docs/memory/model-management.md is excluded by !docs/**
• docs/memory/retrieval.md is excluded by !docs/**
• docs/testing.md is excluded by !docs/**
• docs/ui/patterns/generation-status-pill.md is excluded by !docs/**
• docs/ui/screens/reader-composer/reader-composer.md is excluded by !docs/**

📒 Files selected for processing (95)

• .remarkignore
• app/_layout.tsx
• app/reader-composer/[branchId].tsx
• app/story-settings/[storyId].tsx
• app/wizard.tsx
• components/compounds/embedder-default-card.stories.tsx
• components/compounds/embedder-default-card.tsx
• components/compounds/generation-status-pill.stories.tsx
• components/compounds/generation-status-pill.tsx
• components/embedder/reindex-confirm-dialog.tsx
• components/embedder/swap-dialog.stories.tsx
• components/embedder/swap-dialog.tsx
• components/embedder/swap-resume-dialog.stories.tsx
• components/embedder/swap-resume-dialog.tsx
• components/embedder/swap-resume-host.tsx
• components/story-settings/memory-panel.stories.tsx
• components/story-settings/memory-panel.tsx
• components/wizard/finish.test.ts
• components/wizard/finish.ts
• components/wizard/memory-cost-disclosure.stories.tsx
• components/wizard/memory-cost-disclosure.tsx
• components/wizard/memory-cost-logic.test.ts
• components/wizard/memory-cost-logic.ts
• components/wizard/step-opening.tsx
• e2e/harness/embedder.ts
• e2e/harness/seed.ts
• e2e/locators/reader.ts
• e2e/locators/story-settings.ts
• e2e/tests/embedder-drain.spec.ts
• e2e/tests/embedder-swap.spec.ts
• lib/actions/embedder-swap/app-deps.test.ts
• lib/actions/embedder-swap/app-deps.ts
• lib/actions/embedder-swap/engine.test.ts
• lib/actions/embedder-swap/engine.ts
• lib/actions/embedder-swap/index.ts
• lib/actions/index.ts
• lib/actions/settings/embedder.test.ts
• lib/actions/settings/embedder.ts
• lib/actions/settings/index.ts
• lib/actions/settings/providers.ts
• lib/actions/stories/operational.ts
• lib/ai/embedding.test.ts
• lib/ai/embedding.ts
• lib/ai/model-capabilities.ts
• lib/boot/bootstrap.ts
• lib/db/app-settings/app-settings-schema.test.ts
• lib/db/app-settings/app-settings-schema.ts
• lib/db/embeddings/field-rows.test.ts
• lib/db/embeddings/field-rows.ts
• lib/db/embeddings/index.ts
• lib/db/embeddings/ops.test.ts
• lib/db/embeddings/ops.ts
• lib/db/embeddings/stale.test.ts
• lib/db/embeddings/stale.ts
• lib/db/embeddings/vec-tables.test.ts
• lib/db/embeddings/vec-tables.ts
• lib/db/entities/entities.table.ts
• lib/db/happenings/happenings.table.ts
• lib/db/index.ts
• lib/db/lore/lore.table.ts
• lib/db/migrations/0006_absent_natasha_romanoff.sql
• lib/db/migrations/meta/0006_snapshot.json
• lib/db/migrations/meta/_journal.json
• lib/db/migrations/migrations.js
• lib/db/runtime/exec.native.ts
• lib/db/runtime/exec.ts
• lib/db/stories/settings-ops.test.ts
• lib/db/stories/settings-ops.ts
• lib/db/stories/story-config-schema.test.ts
• lib/db/stories/story-config-schema.ts
• lib/db/stories/story-settings-defaults.test.ts
• lib/db/stories/story-settings-defaults.ts
• lib/db/story-entries/story-entries.table.ts
• lib/db/threads/threads.table.ts
• lib/db/wizard-sessions/working-state.ts
• lib/embedder/drain.test.ts
• lib/embedder/drain.ts
• lib/embedder/gate.test.ts
• lib/embedder/index.ts
• lib/embedder/resolve-config.test.ts
• lib/embedder/resolve-config.ts
• lib/embedder/service.test.ts
• lib/embedder/service.ts
• lib/embedder/types.ts
• lib/stores/generation/generation.ts
• lib/stores/index.ts
• lib/stores/ui/embedder-swap.test.ts
• lib/stores/ui/embedder-swap.ts
• lib/stores/ui/embedding-status.test.ts
• lib/stores/ui/embedding-status.ts
• lib/stores/wizard/wizard.test.ts
• lib/stores/wizard/wizard.ts
• locales/en/common.json
• locales/en/story-settings.json
• locales/en/wizard.json

[failerko]

Nitpick disposition (the six in the review body have no inline threads):

Taken

• lib/actions/embedder-swap/index.ts — SwapMarkerChangedError + SwapCancelOutcome exported (3ce9cf8).
• lib/actions/index.ts — raw engine primitives dropped from the app-wide barrel (3ce9cf8). Nothing outside lib/actions/embedder-swap imported them; the engine tests import from ./engine intra-module.
• settings-ops.ts — setSwapTargetDimOp test added (b9cb482).
• locales/en/wizard.json — the untranslatable ch is gone and both strings take {{chapters}} off one exported constant (111710f). Note PROJECTED_ROWS_30CH was a ROW count (2250), not a chapter count, so this needed a separate PROJECTED_CHAPTERS; the rows constant is now PROJECTED_ROWS so its name no longer embeds a number it does not hold.
• memory-panel.tsx / swap-resume-host.tsx — shared hook extracted (b0066a3). The error reporter was byte-equivalent between the two and the resume/cancel cores matched down to the already-completed toast; only the pre-steps differed, and those stay at the call sites.

Not taken

• exec.native.ts queryRows. Splitting the finding: getAllSync → getAllAsync is a one-line change that moves the work off the JS thread and is the real win (the symptom is a frozen Android UI during a re-index, not slow indexing). Incremental/chunked loading is the genuinely heavy part — the swap engine loads the full row set up front and batches embeds at 16, so making the LOAD incremental changes the queryAll contract across engine.ts, stale.ts and field-rows.ts. Holding both: exec.native.ts is Android-only and Vitest exercises the node-sqlite path, so nothing in this repo would verify either change, and I am not shipping an unverifiable edit to a driver seam. Desktop goes through exec.ts and is unaffected.

Full suite green: 2265 tests, typecheck, ESLint, remark.