Skip to content

fix(cli): report config warnings once per build - #1762

Merged
nathanschmid08 merged 1 commit into
Avenx-JS:mainfrom
awais-ur-rehman:feat/config-warning-once
Nov 15, 2026
Merged

nathanschmid08 merged 1 commit into
Avenx-JS:mainfrom
awais-ur-rehman:feat/config-warning-once

Conversation

@awais-ur-rehman

Copy link
Copy Markdown
Contributor

What this changes

The build command reuses the configuration the CLI already loaded, so each unknown option produces one warning. The configuration guide now points to the app constructor and runtime flag for performance profiling.

Related issue

Closes #1751

How was this verified?

  • The CLI system regression reproduced two warnings per key and now expects exactly one for each of two unknown keys.
  • Compiler snapshots matched all six fixtures. Repository lint passed.
  • The full suite passed 345 of 346 files on the first run. The filesystem watcher test timed out waiting for an event and passed when run on its own.

Prepared with assistance from OpenAI Codex.

Checklist

  • npm test passes
  • npm run lint passes
  • Tests added or updated where appropriate
  • Documentation updated where user-facing behavior changed
  • If a diagnostic code was added, the steps in CONTRIBUTING.md were followed

No diagnostic code was added.

@nathanschmid08 nathanschmid08 self-assigned this Nov 15, 2026
@nathanschmid08
nathanschmid08 self-requested a review November 15, 2026 16:44

@nathanschmid08 nathanschmid08 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@nathanschmid08

Copy link
Copy Markdown
Member

@all-contributors please add @awais-ur-rehman for code

@allcontributors

Copy link
Copy Markdown
Contributor

@nathanschmid08

I've put up a pull request to add @awais-ur-rehman! 🎉

@nathanschmid08

Copy link
Copy Markdown
Member

Hi @awais-ur-rehman , Thanks for the PR. I really appreciate it.

I just finished my review and everything looks good, therefore I will now merge your PR.

Thanks again for the great work and have a great start in the new week!

@nathanschmid08
nathanschmid08 merged commit d917e30 into Avenx-JS:main Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: enableProfiling is documented as a config option and rejected by the loader, and the warning prints twice

2 participants