Does not work well in mobile devices #10 (images hover preview) hacktoberfest#16
Open
yhau1989 wants to merge 1 commit into
Open
Does not work well in mobile devices #10 (images hover preview) hacktoberfest#16yhau1989 wants to merge 1 commit into
yhau1989 wants to merge 1 commit into
Conversation
Author
|
Hey @AviKKi we can use Intersection_Observer_API ?? Could generate a new branch and a new pull request? |
Owner
|
Hey @yhau1989 this doesn't look very good, opera mini, UC browser and iOS 12.1 will be left out which is major portion of mobile users. I've had the look at the code of pornhub.com their approach is very simple with a great UX, so I'm heading up with that. Their method for mobile - due to this simple approach there is no way to stop the preview once it's started, small loop hole w.r.t. the simplicity and UX we get. Stopping the preview using Intersection_Observer_API sounds nice to me. PS: Later I may add options for multiple preview triggers, but for now since #18 is not yet done. I"m sticking with this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
suggested that pornhub.com has this type of UX for thumbnail preview