Skip to content

chore(core): strict TS + typed ESLint#158

Open
morapay-app wants to merge 1 commit into
Axionvera:mainfrom
morapay-app:issue-69-strict-ts-eslint
Open

chore(core): strict TS + typed ESLint#158
morapay-app wants to merge 1 commit into
Axionvera:mainfrom
morapay-app:issue-69-strict-ts-eslint

Conversation

@morapay-app
Copy link
Copy Markdown

Summary

  • Enforced TS strictness required by Enforce strict TypeScript compilation and linting #69 (strict, noImplicitAny, exactOptionalPropertyTypes).
  • Configured type-aware ESLint (@typescript-eslint/strict-type-checked + @typescript-eslint/stylistic-type-checked) with a dedicated tsconfig.eslint.json and parserOptions.project.
  • Unblocked CI by aligning the toolchain so installs/tests run deterministically (ts-jest currently requires TypeScript < 6, so the root TS devDependency is pinned to a compatible 5.9.x line).

Notes / rationale

  • This PR includes follow-up fixes that became mandatory once strictness + typed linting were enabled (API surface mismatches, optional-property semantics, and monorepo typecheck ordering).

Acceptance criteria coverage

  • TS config: strict, noImplicitAny, exactOptionalPropertyTypes enabled.
  • ESLint: strict-type-checked + stylistic-type-checked enabled; parserOptions.project points to tsconfig.eslint.json.
  • Lint/typecheck/tests run successfully.

Test plan

  • npm install
  • npm run typecheck
  • npm run lint
  • npm test

Made with Cursor

\n- Enable exactOptionalPropertyTypes/noImplicitAny\n- Add type-aware ESLint config and monorepo typecheck order\n- Fix build/typecheck/lint/test regressions uncovered by strictness\n

Made-with: Cursor
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Apr 25, 2026

Hey @morapay-app! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#101 Implement Hardware Wallet Connector (Ledger/Trezor) Link to this issue
#70 Setup size-limit to monitor bundle size Link to this issue
#69 Enforce strict TypeScript compilation and linting Link to this issue

ℹ️ Learn more about linking PRs to issues

@AlAfiz
Copy link
Copy Markdown
Contributor

AlAfiz commented May 1, 2026

@morapay-app please resolve conflicts and link issue to pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants