Skip to content

Conversation

@brainlessbitch
Copy link

simple brightness lib, idk, this is needed imo

@kotontrion
Copy link
Collaborator

here are my 2 cents:
make the backlight_model property construct only
add a BrightnessManager class, which creates creates an instance of the Brightness class for each available device.
Also leds follow the same directory structure (at /sys/class/leds/), so with this approach we can also support things like numlock, capslock, keyboard backlight, etc. See #336

Then to make usage easier, the brightness manager might also have a brightness property, which either acts as a proxy for just one display backlight, or maybe better set the brightness for all display backlights, similar to the volume prop in the AstalWp nodes with multiple channels.

@ItsLiyua
Copy link

I'd be interested in something like this

@brainlessbitch
Copy link
Author

here are my 2 cents: make the backlight_model property construct only add a BrightnessManager class, which creates creates an instance of the Brightness class for each available device. Also leds follow the same directory structure (at /sys/class/leds/), so with this approach we can also support things like numlock, capslock, keyboard backlight, etc. See #336

Then to make usage easier, the brightness manager might also have a brightness property, which either acts as a proxy for just one display backlight, or maybe better set the brightness for all display backlights, similar to the volume prop in the AstalWp nodes with multiple channels.

i can 100% do all this, sorry for missing the comment will get the pr updated when i have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants