Fix iOS dark appearance backgrounds#27
Conversation
Greptile SummaryThis PR fixes iOS dark mode by replacing hard-coded white backgrounds in
Confidence Score: 5/5Safe to merge — the adaptive color is correctly wired through the asset catalog and both storyboards; the embedded namedColor fallbacks are design-time only and don't affect runtime dark-mode behaviour. All changed files are iOS resource files and test code. The asset-catalog hex values match the Flutter TagTheme palette exactly. Runtime named-color resolution goes through the asset catalog (which has both variants), so the embedded light-only namedColor in the storyboards is only a design-time concern. Both storyboard files embed a light-only namedColor fallback; no second look needed for correctness, but IB dark-mode previews will show the wrong colour until the dark appearance entry is added. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["iOS system trait collection\n(light / dark)"] --> B{"Asset catalog\nnamed-color lookup\ncolorNamed: LaunchBackground"}
B -->|light| C["#F8F7F2\n(warm off-white)"]
B -->|dark| D["#0F1115\n(near-black)"]
C --> E["LaunchScreen.storyboard\nbackgroundColor"]
D --> E
C --> F["Main.storyboard\n(Flutter host VC)\nbackgroundColor"]
D --> F
E --> G["Launch screen rendered\nby iOS before app code"]
F --> H["Flutter engine\nmounts on top"]
I["Storyboard namedColor\nin resources section"] -.->|IB design-time\nfallback only\nlight variant only| E
I -.->|IB design-time\nfallback only\nlight variant only| F
Reviews (2): Last reviewed commit: "Fix iOS dark appearance backgrounds" | Re-trigger Greptile |
7d0fd82 to
5846b8b
Compare
Summary
Fixes #26.
Validation
flutter analyzeflutter testflutter build ios --simulator --debugxcrun ibtool --errors --warnings --noticesonLaunchScreen.storyboardandMain.storyboard