Fix/macos audio crash#358
Open
guidiguidi wants to merge 2 commits into
Open
Conversation
Investigation showed that immediate crashes occurred during microphone access due to unhandled exceptions in native layers. Changes: - Implemented @try-@catch guards around critical AVFoundation and CoreAudio calls. - Migrated device discovery to AVCaptureDeviceDiscoverySession for better stability on macOS 10.15+. - Enforced proper Platform namespace usage and added missing headers for media_audio_capture. - Added defensive null checks for AVCaptureDevice objects.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves macOS smoothness by reducing two common sources of micro-stutters:
What changed
Why
On macOS (especially newer versions), CoreAudio can emit bursts of device-related notifications even without user action. Forcing full device refreshes immediately can lead to periodic UI micro-stutters.
Similarly, chat list scrolling can trigger frequent visible-range updates; coalescing the heavy part improves perceived FPS and reduces jank.
Test plan
Notes