fix: remove deleted messages from shared media index to fix incorrect counts#385
Open
denfry wants to merge 1 commit into
Open
fix: remove deleted messages from shared media index to fix incorrect counts#385denfry wants to merge 1 commit into
denfry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saveDeletedMessagesis on, messages are kept in memory viasetDeleted()instead ofdestroy()destroy()goes throughHistory::destroyMessage()which dispatchesSharedMediaRemoveOneto update the Photos/Links/Files counts in the peer profilesetDeleted()did not callremoveFromSharedMediaIndex(), so deleted messages remained counted in the shared media totalsFix
Call
removeFromSharedMediaIndex()at the end ofsetDeleted()so the shared media counts stay accurate when a message is marked as deleted.Closes #174
This PR was AI generated.