Repository navigation
P5b-fix: an unresolved security-group entry must not give PASS (INV-FUNC-001) - #23
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…w 4; the engine is compared exactly (registry §6.3 E2, E3; §6.4 row 4; C-156) The 21 new tests were written and shown failing first (12 of 19 failed on the old code: the reviewer's reproductions on D and on S, a placeholder group, the path not established, the engine casing). The fix adds the side-level unresolved reasons to the row 4 reasons when a side is read, and compares the engine with the exact string "postgres". Two P5b tests asserted the superseded results for an unresolved entry of S (PASS row 6; row 7 with no path); they now assert UNKNOWN, row 4 (C-156 rule 2). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…egistry §6.3, §6.4; C-155, C-156) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P5b-fix: an unresolved security-group entry must not give PASS (INV-FUNC-001)
An unresolved entry in
vpc_security_group_ids(a variable, aconcatwith a variable, a group of unknowncount) could reach row 6 and give PASS when the known groups established the path. Registry §6.3 E3 requires every entry to be resolved and §6.4 row 4 gives UNKNOWN. This PR makes it row 4, on both D and S, and compares the engine with the exact stringpostgres(E2).Process (C-28): do not merge until the external review verdict is pasted into this PR. This description contains no verdict.
Changes
docs/PHASE_GATES.md, as supplied.core/verification/reachability.py(6 lines): a side's unresolved entries now reach the row 4 reasons; the engine is compared exactly.tests/unit/test_reachability_unresolved_groups.py, written and shown failing first (12 of 19 failed on the old code).For the reviewer
PHASE_GATES.mdstill has the heading "P5b–P10 — NOT STARTED" below the P5b block (left as instructed).Evidence
dev.py testOK on 3.12 and 3.14 (skipped=2); black, ruff, mypy clean; pytest 3507 passed, 1 skipped.🤖 Generated with Claude Code