Repository navigation
P7a: the LLM channel (provider seam, fake and local Ollama providers, context, prompts, parser, retries) - #28
Merged
Merged
Conversation
… the verdict; CLAUDE.md and README match C-71 (Doc 10 §30; C-71, C-181 to C-186) C-181 accepted as built (authors); C-182 the only real provider is a local Ollama server (advisor); C-183 to C-186 Proposed (stdlib only, the patch format, Ollama structured output, the wiring model). The P6d section of PHASE_GATES now records the verdict (merged as 1c3d72b, tagged registry-v1.1) and its six carried limits, as the user asked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…providers, context, budget, prompts, strict parser, retries, records (Doc 10 §6-§11, §16-§25, §30-§34; Doc 14 §37; C-182 to C-186) Standard library only (C-183). The patch field carries PatchFormat.TERRAFORM_HCL text (C-184). Ollama's format parameter gets the response schema, and the strict parser still checks every reply (C-185). Only loopback URLs are accepted (C-71). generation_enabled off makes no provider call. The default suite opens no socket (a test blocks them). llm.provider accepts "ollama"; mypy now also checks llm/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ned model; ADR-006; C-187; the P7a stub in PHASE_GATES (Doc 10 §30, §36; Doc 02 §26; C-182 to C-187) Ollama 0.40.16 (official installer, signed by Ollama Inc.); qwen2.5-coder:1.5b, digest d7372fd8...a0668, Q4_K_M, Apache-2.0 (library page and ollama show --license). One run on the canonical objective: PATCH, no parse errors, 31.7 s. The patch was not turned into a candidate (P7b). No gate is claimed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P7a — the LLM channel
Branch
feature/p7afromorigin/mainat1c3d72b. No gate or mini-gate is claimed. The external review verdict is the approval record (C-28), so this must not be merged before it. P7b (patch validation into a Candidate State, the P7 gate and M4) follows.Decisions
What exists
llm/adapter/provider.py. Providers:fake.pyandollama.py(urllib, loopback addresses only, digest pin).dail-repair-prompt-1(template hash pinned per version; infrastructure text sent as delimited data).dail-llm-parser-1(§11, §22, §25), retries (§23), records and observability (§16, §20, §21, §32, §34).llm.generation_enabled; when off, no provider is called.Wiring check (one run, local CPU)
qwen2.5-coder:1.5b, digestd7372fd828518a4d38b1eb196c673c31a85f2ed302b3d1e406c4c2d1b64a0668, Q4_K_M, Apache-2.0 (library page andollama show --license).Checks (Python 3.12.10)
dev.py test: 4234 tests OK (skipped=2: the opt-in Ollama test, and the symbolic-link test)dev.py lint: black, ruff and mypy clean (mypy now also checksllm/)Review verdict: (link to be added)
🤖 Generated with Claude Code