Repository navigation
P7b: from LLM patch to Candidate State (validator, scope, LLMEvaluationRequest, P7 gate map) - #29
Merged
Merged
Conversation
…, C-189 to C-193 Proposed, C-194 (api_key_ref kept); CLAUDE.md drops the Pydantic allowance (Doc 10 §12-§15; C-174, C-183) C-194: the user decided to keep llm.api_key_ref, because it is the only secret-reference key and about ten config tests exercise the secret machinery through it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…est; scope and operation check; parser 2, prompt 2 (Doc 10 §12-§15, §22, §27, §35, §38-§40; Doc 03 §4.5-§4.7; C-188 to C-193) llm/validation/patch.py runs the §13 checks in order (syntax, top-level blocks, forbidden constructs, boundaries, scope, credentials, invented ids, build in a fresh directory, references, normalize, identity with the operation check). The parent directory is never written. AllowedChangeScope and operation_breaches live in core.domain.change_scope. LLMEvaluationRequest binds a built directory to its patch by tree hash. The parser keeps only the format checks (dail-llm-parser-2). The prompt is dail-repair-prompt-2; v1 stays reproducible. P7a tests whose expectations C-190 and C-193 supersede are updated with notes: the scope check moved from the parser to the validator, a stub validator keeps all eight failure classes in the mapping test, the prompt version is now 2, and the context takes the caller's scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ports (mutation V9 survived otherwise) (Doc 10 §13 step 7; C-192) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e P7 gate map in PHASE_GATES; BUILD_SEQUENCE (Doc 15 §14.2, §24; C-188 to C-195) Wiring check with the local model (qwen2.5-coder:1.5b, the P7a digest): PATCH, validated, built, DAIL decision REJECT, 1 attempt, 23.0 s; Trusted State unchanged. Every §14.2 and M4 item maps to named tests; no gate is marked passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P7b — from LLM patch to Candidate State
Branch
feature/p7b, created fromorigin/mainat7ea06b0. Finishing P7b closes P7 and milestone M4, but no gate, mini-gate or milestone is claimed; the external review decides (C-28). Do not merge before the verdict.Decisions
llm.api_key_refstays in the config schema because about ten secret-machinery tests depend on it.CLAUDE.mdno longer allows Pydantic inllm/.What exists
llm/validation/patch.py,dail-patch-validator-1): runs the checks in the order of Doc 10 §13, as Section 4 of the work package lists them, with failure classes per C-192.core/domain/change_scope.py):AllowedChangeScope, plus the operation check, which runs after DAIL's own identity engine.LLMEvaluationRequest, a subclass ofEvaluationRequestbound to the built directory by its tree hash. It goes through the same orchestrator, so promotion stays the only route to a new Trusted State.dail-llm-parser-2; promptdail-repair-prompt-2, with version 1 still reproducible.Wiring check (one run, local CPU)
qwen2.5-coder:1.5b, digestd7372fd8…a0668, the same as in P7a.Checks (Python 3.12.10)
dev.py test: 4292 tests OK, 3 skipped (2 opt-in Ollama tests and the symbolic-link test).dev.py lint: black, ruff and mypy clean.The P7 gate map in
docs/PHASE_GATES.mdmaps each Doc 15 §14.2 item and each M4 item to named tests.Review verdict: (link to be added)
🤖 Generated with Claude Code