Fix CORS methods parsing to support wildcard#168
Closed
railway-app[bot] wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FastAPI's CORSMiddleware rejects
"*"as an HTTP method value, so whenCORS_METHODSis set to"*"the existing comma-split logic produces["*"], which the middleware cannot recognise. This causes every CORS preflight OPTIONS request to/api/v1/contact-messagesto fail with HTTP 400, breaking the contact form.Solution
Updated
cors_methods_listinapp/config/settings.pyto detect the wildcard and return the full list of real HTTP method names (GET, POST, PUT, DELETE, PATCH, OPTIONS, HEAD, TRACE, CONNECT) instead of passing"*"directly to the middleware. Thecors_headers_listproperty is also guarded to return["*"]explicitly when the wildcard is set, since FastAPI does accept"*"for headers. Non-wildcard values continue to be split by comma as before.Changes
app/config/settings.pyGenerated by Railway