Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates multiple development epics into a production-ready release:
Changes by area
Domain
WorkExperience: addlocation,is_current,duration_monthsfieldsEducation&AdditionalTraining: add optionaltechnologiesfieldProject: add optionalimage_urlfieldSkill: removecategoryfield across all layersTool: makecategoryoptionalApplication / Infrastructure
GetCompleteCVUseCase: fix aggregation to include all entities usingdefault_profileCreateContactMessageUseCase: integrate email notification on new messageupdate()methods: fix bug where_idwas included in the replacement documentSkillUseCase: fixorder_indexpropagation through the full PUT pipelineResendEmailService; addNullEmailServicefor non-productionenvironments
IEmailServiceinterface added toshared/interfaces/API
WorkExperienceRequest,ProjectRequest, etc.)ToolBase.categorymade optionalSkillSchema: removecategoryreferencesTesting
exception class
Infrastructure / Deployment
Dockerfile(production) created for Railway —python:3.13-slim, no--reloadrequirements.txtconverted from UTF-16 to UTF-8; cleaned up.env.exampleupdated with Resend variablesTesting checklist
make testpasses with no failures inside the containertest_complete_cv_flow.pypasses end-to-endPOST /api/v1/contact-messagestriggers an email via Resend (staging key)GET /api/v1/cvreturns all sections includinglocation,technologies,image_urlGET /api/v1/skillsreturns skills withoutcategoryfield