Entraid auth clean#294
Draft
jjsanchezms wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
InteractiveBrowserCredential+ direct ACS token exchange usingAzureCommunicationTokenCredential(resource + Entra federated auth flow)./entraConfig) when build‑time environment variables are not supplied.?groupId=...&entra=1(auto triggers auth on load).EntraAuthStatus) showing auth state and retry UX.Pull Request Type
Upstream sample reference
Links to PR(s) that made the original change in the upstream sample:
How to Test
(Windows PowerShell example – set build-time env vars before start; or skip and rely on server fallback.)
Alternative (option 2 – fallback): Put these in
Server/appsettings.json(add keys if missing):Then just run:
Manual test steps:
What to Check
Verify that the following are valid
groupIdandentra=1; sharing it triggers automatic auth attempt once (no infinite retries)./entraConfigworks when build-time env vars are omitted (observe successful JSON response).Other Information
@azure/identity(client). UsesInteractiveBrowserCredentialwith scopehttps://communication.azure.com/clients/VoIPand Graph token parsing for user display info (JWT claim decode only—no Graph REST call).communicationUserIdis generated when Entra path doesn’t supply an ACS user id (format:entra-<oid/email>); sufficient for UI adapter identity consistency.autoEntraTriedRef)./entraConfigenables deployments where front-end is built once and config is injected at runtime.