chore: replace rimraf with native fs.rm()#2631
Open
roli-lpci wants to merge 1 commit intoAzure:mainfrom
Open
Conversation
Remove the rimraf package (and @types/rimraf) by replacing all usages with Node.js built-in fs.promises.rm(), which has been stable since Node 14.14.0. This removes one production dependency from the bundle. Source code: rimrafAsync in src/common/utils/utils.ts is now a thin wrapper around fs.promises.rm with recursive + force options and Windows-specific maxRetries for EPERM resilience. Test code: rmRecursive in tests/testutils.ts uses the same approach. npm scripts: clean/clean:deep now use scripts/clean.js, a zero-dependency Node script that handles both static paths and glob patterns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rimrafdependency with Node.js built-infs.rm()with{ recursive: true, force: true }rimraffrompackage.jsondependenciesThis aligns with the e18e ecosystem cleanup initiative —
rimrafis a thin wrapper aroundfs.rm()which has been available since Node.js 14.14.0.Test plan
npm testpassesrimrafin source