-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Updating exemption for securityContacts to reflect the expected, as of both MCSB and what the policy deploys #1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…f both MCSB and what the policy deploys
|
@Springstone Hey, j just updated with a another linter so it follows what you require, so need a new review :) |
|
@jtracey93, @Springstone |
…n and enhance security policies for Azure storage services
…e security policies for Azure storage services
…reflect updated policy Update Deploy-ASC-SecurityContacts version and update policy file to reflect updated policy
|
@Springstone and/or @jtracey93 Any change that one of you can take a look at this PR? :) |
|
@JonasCordsen apologies for the delay in getting back to you. A lot of change is impacting our focus. |
|
Hello @Springstone Thank you for getting back to me. If there is anything I can do or change in this, please let me know |
|
Hi @JonasCordsen. Sorry for the huge gap in response... most of the folks in this team have moved around, and we have other priorities - but we're getting back to business. For this PR, we have bigger issues as currently, this policy is never compliant due to alias/API changes. New additions like "attack path", the change of severity levels to string instead of array, etc. I'm trying to get it to work with your contribution and will include it in the upcoming policy refresh. You will get credit for your contribution in What's New for sure, maybe not through this PR though. Hope you understand. |
Updating exemption for securityContacts to reflect the expected, as of both MCSB and what the policy deploys
Overview/Summary
The securityContacts does not evaluate if the notificationsByRole is set, so if previous settings had been made, this policy would be compliant, but he audit from MCSB would be non-compliant
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Adding the definition to my own branch, and ensuring the when to non-compliant and that a remediation of the policy caused the subscriptions to become compliant
Testing URLs
The below URLs can be updated where the placeholders are, look for
{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}&{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.Azure Public
Azure US Gov (Fairfax)
As part of this Pull Request I have
mainbranch/docs/wiki/whats-new.md)