[CosmosDB] az cosmosdb update: Add support for Microsoft Fabric workspace resource IDs in --network-acl-bypass-resource-ids
#32761
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
evelyn-ys,
jsntcy,
kairu-ms and
yonzhan
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution @dgao97! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
Auto-Assign
|
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Pull request overview
Adds support in az cosmosdb update for validating Microsoft Fabric workspace resource IDs passed via --network-acl-bypass-resource-ids, alongside existing standard ARM /subscriptions/... resource IDs.
Changes:
- Introduces
is_valid_network_acl_bypass_resource_id()to validate both standard ARM resource IDs and Fabric/tenants/...resource IDs. - Updates
cli_cosmosdb_update()to use the new validator for--network-acl-bypass-resource-ids. - Adds a scenario test + recording covering both standard and Fabric resource ID update flows.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/cosmosdb/custom.py | Switches --network-acl-bypass-resource-ids validation to the new validator supporting Fabric IDs. |
| src/azure-cli/azure/cli/command_modules/cosmosdb/_validators.py | Adds Fabric-aware resource ID validation helper used by cosmosdb update. |
| src/azure-cli/azure/cli/command_modules/cosmosdb/tests/latest/test_cosmosdb_commands.py | Adds live scenario test verifying standard + Fabric resource ID behavior. |
| src/azure-cli/azure/cli/command_modules/cosmosdb/tests/latest/recordings/test_cosmosdb_network_acl_bypass.yaml | Recording for the new scenario test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def _is_valid_guid(value): | ||
| """Check if a string is a valid GUID.""" | ||
| import uuid | ||
| try: | ||
| uuid.UUID(value) | ||
| return True | ||
| except ValueError: | ||
| return False |
There was a problem hiding this comment.
_is_valid_guid currently uses uuid.UUID(value) which accepts non-canonical GUID representations (e.g. urn:uuid:<guid>, {<guid>}, or 32-hex-without-dashes). Because the Fabric resource ID regex captures (.+), these non-ARM forms would be treated as valid IDs even though they are not valid path segments in an ARM resource ID. Consider tightening validation to require the canonical 36-char hex-with-dashes form (e.g. validate with a GUID regex, or compare str(uuid.UUID(value)) == value.lower()), and/or tighten the capture groups in the Fabric regex to a GUID pattern.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
calvinhzy
changed the title
az cosmosdb update: Add support for Microsoft Fabric workspace resource IDs in --network-acl-bypass-resource-ids
calvinhzy
changed the title
az cosmosdb update: Add support for Microsoft Fabric workspace resource IDs in --network-acl-bypass-resource-idsaz cosmosdb update: Add support for Microsoft Fabric workspace resource IDs in --network-acl-bypass-resource-ids
4 participants
Related command
az cosmosdb update -n {acc} -g {rg} --network-acl-bypass AzureServices --network-acl-bypass-resource-ids /tenants/{tenantId}/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/Fabric/providers/Microsoft.Fabric/workspaces/{workspaceGuid}
Description
This PR adds support for Microsoft Fabric workspace resource IDs in the
--network-acl-bypass-resource-idsparameter foraz cosmosdb update.Previously, only standard Azure resource IDs (starting with
/subscriptions/) were accepted. This change extends validation to also accept Fabric resource IDs in the format:/tenants/{tenantId}/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/Fabric/providers/Microsoft.Fabric/workspaces/{workspaceGuid}Changes:
is_valid_network_acl_bypass_resource_id()function in_validators.pythat validates both standard Azure resource IDs and Fabric resource IDscli_cosmosdb_update()incustom.pyto use the new validation functionTesting Guide
History Notes
[CosmosDB]
az cosmosdb update: Add support for Microsoft Fabric workspace resource IDs in--network-acl-bypass-resource-idsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.