fix: add missing env vars for binary tag release channel notification - #4765
Open
Behzad Mirkhanzadeh (behzad-mir) wants to merge 1 commit into
Open
fix: add missing env vars for binary tag release channel notification#4765Behzad Mirkhanzadeh (behzad-mir) wants to merge 1 commit into
Behzad Mirkhanzadeh (behzad-mir) wants to merge 1 commit into
Conversation
Behzad Mirkhanzadeh (behzad-mir)
requested a review
from a team
as a code owner
August 26, 2026 21:54
Copilot started reviewing on behalf of
Behzad Mirkhanzadeh (behzad-mir)
August 26, 2026 21:55
View session
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the notify_release_channel job in .github/workflows/create-release-tag.yml by adding the missing environment variables required by release-cli notify, aligning it with the notification configuration already present in scheduled-release.yaml. This addresses the observed failure when approving binary tags (e.g., team-id is required (or set TEAMS_TEAM_ID)).
Changes:
- Add
TEAMS_TEAM_IDto thenotify_release_channeljob environment. - Add
NOTIFIER_URLandNOTIFIER_AUDIENCEto thenotify_release_channeljob environment to support OIDC-authenticated notifier calls.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
The notify_release_channel job in create-release-tag.yml was missing TEAMS_TEAM_ID, NOTIFIER_URL, and NOTIFIER_AUDIENCE env vars needed by release-cli notify. These are set at workflow level in scheduled-release.yaml but were not carried over to create-release-tag.yml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 138a957a-e271-4f92-89b0-3b80edc3ffd5
Behzad Mirkhanzadeh (behzad-mir)
force-pushed
the
fix/binary-tag-notify-env
branch
from
September 11, 2026 18:42
169ca28 to
abdc7b0
Compare
Behzad Mirkhanzadeh (behzad-mir)
requested a review
from a team
as a code owner
September 11, 2026 18:42
Copilot started reviewing on behalf of
Behzad Mirkhanzadeh (behzad-mir)
September 11, 2026 18:42
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
notify_release_channeljob increate-release-tag.ymlwas missingTEAMS_TEAM_ID,NOTIFIER_URL, andNOTIFIER_AUDIENCEenv vars needed byrelease-cli notify. These are set at workflow level inscheduled-release.yamlbut were not carried over tocreate-release-tag.yml.Error seen after approving binary tags:
Fixes the notification failure for binary tag approvals (dropgz, azure-ipam, etc.).