Skip to content

ci: fix false-positive issue dedup in go-version-check #4834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Behzad Mirkhanzadeh (behzad-mir) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: fix false-positive issue dedup in go-version-check #4834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions .github/workflows/go-version-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,13 @@ jobs:
"
fi

# Dedup: skip if an open issue already exists for this update
EXISTING_ISSUE=$(gh issue list --repo "$REPO" --state open --search "$MARKER" --json number --jq '.[0].number // empty')
# Dedup: skip if an open issue already exists for this update.
# Match the marker as an exact substring of the body. Do NOT use
# `gh issue list --search`: GitHub's full-text index tokenizes markers
# like `go-patch-update:1.26.8` on `-`, `:` and `.`, so it returns
# false positives (unrelated issues) and silently suppresses creation.
EXISTING_ISSUE=$(gh issue list --repo "$REPO" --state open --limit 200 --json number,body \
| jq -r --arg m "$MARKER" 'map(select((.body // "") | contains($m))) | .[0].number // empty')
Comment on lines +328 to +329
if [ -n "$EXISTING_ISSUE" ]; then
echo "::notice::Issue #$EXISTING_ISSUE already exists for this update — skipping"
exit 0
Expand Down Expand Up @@ -445,7 +450,9 @@ jobs:
GOEXP_CGO0: ${{ steps.prereqs.outputs.goexp_cgo0 }}
run: |
MARKER="fips-prereq:${MATRIX_BRANCH}"
EXISTING_ISSUE=$(gh issue list --repo "$REPO" --state open --search "$MARKER" --json number --jq '.[0].number // empty')
# Exact substring match — see note on dedup in the auto-bump job.
EXISTING_ISSUE=$(gh issue list --repo "$REPO" --state open --limit 200 --json number,body \
| jq -r --arg m "$MARKER" 'map(select((.body // "") | contains($m))) | .[0].number // empty')
if [ -n "$EXISTING_ISSUE" ]; then
echo "::notice::Prerequisite issue #$EXISTING_ISSUE already exists — skipping"
exit 0
Expand Down Expand Up @@ -496,7 +503,9 @@ jobs:

# Dedup
MARKER="go-backport:${MATRIX_BRANCH}:${UPDATE_TYPE}"
EXISTING_ISSUE=$(gh issue list --repo "$REPO" --state open --search "$MARKER" --json number --jq '.[0].number // empty')
# Exact substring match — see note on dedup in the auto-bump job.
EXISTING_ISSUE=$(gh issue list --repo "$REPO" --state open --limit 200 --json number,body \
| jq -r --arg m "$MARKER" 'map(select((.body // "") | contains($m))) | .[0].number // empty')
if [ -n "$EXISTING_ISSUE" ]; then
echo "::notice::Backport issue #$EXISTING_ISSUE already exists — skipping"
exit 0
Expand Down Expand Up @@ -573,13 +582,17 @@ jobs:
REPO: ${{ github.repository }}
run: |
MARKER="go-minor-update:${LATEST_MINOR}"
# Exact substring match — see note on dedup in the auto-bump job.
# The previous `--search "in:body $MARKER"` matched unrelated issues
# (e.g. "Release Tracking" issues) and blocked issue creation entirely.
EXISTING=$(gh issue list \
--repo "$REPO" \
--state open \
--search "in:body $MARKER" \
--json number \
--jq 'length')
--limit 200 \
--json number,body \
| jq --arg m "$MARKER" 'map(select((.body // "") | contains($m))) | length')
echo "existing_count=$EXISTING" >> "$GITHUB_OUTPUT"
echo "::notice::Existing open issues matching '${MARKER}': ${EXISTING}"

- name: Fetch MS Go FIPS requirements
id: msgo_fips_tier3
Expand Down
Loading