ci: bump the all-docker-dependencies group across 8 directories with 3 updates - #4837
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are straightforward base-image pin updates with no behavioral code changes, with only a minor Dockerfile comment inconsistency noted for follow-up.
Pull request overview
Updates pinned container base images used by ACN component builds and pipeline Dockerfiles to pick up the latest published digests/tags for the same toolchain generation.
Changes:
- Bump MS Go builder image digest for
mcr.microsoft.com/oss/go/microsoft/golang:1.26-azurelinux3.0across multiple component Dockerfiles. - Update
bpf-prog/ipv6-hp-bpfto usemcr.microsoft.com/oss/go/microsoft/golang:1.26.8-1@sha...(tag + digest). - Bump Fluent Bit runtime image to
mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-18and update Windowsservercore:ltsc2022digest used in the pipeline build Dockerfile.
File summaries
| File | Description |
|---|---|
cns/Dockerfile |
Updates MS Go builder image digest used to build CNS binaries. |
cni/Dockerfile |
Updates MS Go builder image digest used to build CNI binaries. |
cilium-log-collector/Dockerfile |
Updates MS Go builder digest and Fluent Bit runtime tag for the log collector plugin image. |
bpf-prog/ipv6-hp-bpf/linux.Dockerfile |
Bumps MS Go image tag+digest used for building the ipv6-hp-bpf artifact. |
azure-iptables-monitor/Dockerfile |
Updates MS Go builder image digest for the iptables-monitor build stages. |
azure-ipam/Dockerfile |
Updates MS Go builder image digest for the azure-ipam build stages. |
azure-ip-masq-merger/Dockerfile |
Updates MS Go builder image digest for the ip-masq-merger build stage. |
.pipelines/build/dockerfiles/npm.Dockerfile |
Updates Windows servercore:ltsc2022 digest for pipeline packaging. |
.pipelines/build/dockerfiles/cilium-log-collector.Dockerfile |
Updates Fluent Bit runtime tag used in the pipeline artifact packaging image. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # IMG=mcr.microsoft.com/oss/go/microsoft/golang:1.26.7 | ||
| # echo "${IMG}@$(skopeo inspect docker://${IMG} --format '{{.Digest}}')" | ||
| FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26.7@sha256:be14ce4ce048adf5584ce3a0919d21987284e2235b6e7e9bb0e6a01133870be9 AS go | ||
| FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26.8-1@sha256:d6363ab95402a257d6a735189c9741594af2affe17cbd9d49c6c3f6ba78625db AS go |
d04a04e to
281a74a
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The Fluent Bit version was updated in autogenerated Dockerfiles but the corresponding .Dockerfile.tmpl sources still reference the old version, so regeneration/CI may revert or fail consistency checks.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
bpf-prog/ipv6-hp-bpf/linux.Dockerfile:4
- The helper comment for resolving the Go image digest still references 1.26.7, but the FROM line now uses 1.26.8-1. This makes the instructions misleading when updating the digest in the future.
# IMG=mcr.microsoft.com/oss/go/microsoft/golang:1.26.7
# echo "${IMG}@$(skopeo inspect docker://${IMG} --format '{{.Digest}}')"
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26.8-1@sha256:ba131ad163f2058687b1849aba44fab3e61e4d9fef758bd772c3ac597dc57c19 AS go
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Lite
| ARG ARCH | ||
|
|
||
| FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-16 as linux | ||
| FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-18 as linux |
| RUN go build -buildmode=c-shared -a -o out_azure_app_insights.so -trimpath -ldflags "-X main.version=$VERSION" -gcflags="-dwarflocationlists=true" . | ||
|
|
||
| FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-16 as linux | ||
| FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-18 as linux |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
281a74a to
fbcc73a
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The Fluent Bit version bump was applied to generated Dockerfiles but not to their source .Dockerfile.tmpl templates, so regeneration (make dockerfiles) is likely to revert the update.
Review details
Suppressed comments (3)
.pipelines/build/dockerfiles/cilium-log-collector.Dockerfile:5
- This file is autogenerated from
.pipelines/build/dockerfiles/cilium-log-collector.Dockerfile.tmpl, but that template still pins fluent-bit v4.2.3-16. Regeneration will likely revert this change unless the template is updated as well.
FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-18 as linux
bpf-prog/ipv6-hp-bpf/linux.Dockerfile:4
- The helper comment above the base image reference still points to Go 1.26.7, but the Dockerfile now pins 1.26.8-1. This makes the skopeo-inspect instructions misleading when someone refreshes the digest later.
# IMG=mcr.microsoft.com/oss/go/microsoft/golang:1.26.7
# echo "${IMG}@$(skopeo inspect docker://${IMG} --format '{{.Digest}}')"
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26.8-1@sha256:1a08ffa20128fcb5003fc5ee7423b76ff7c1664899e2b4cbca7a758fae09577c AS go
cilium-log-collector/Dockerfile:16
- This Dockerfile is marked as autogenerated (see header) but the source template still references fluent-bit v4.2.3-16; regenerating via
make dockerfileswill likely revert this file back to -16. Updatecilium-log-collector/Dockerfile.tmpl(and regenerate) so the committed output stays consistent with the template.
FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-18 as linux
- Files reviewed: 9/9 changed files
- Comments generated: 0 new
- Review effort level: Lite
fbcc73a to
22d211b
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The cilium-log-collector generated Dockerfiles were updated but their source templates still reference the older Fluent Bit tag, so regeneration will likely revert changes and fail the Dockerfile sync check.
Review details
Suppressed comments (3)
cilium-log-collector/Dockerfile:16
- This file is marked as autogenerated from cilium-log-collector/Dockerfile.tmpl, but the template still references fluent-bit v4.2.3-16, so the next
make dockerfilesrun will revert this change and likely fail the Dockerfile regeneration check. Update the template(s) to v4.2.3-18 as well.
FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-18 as linux
.pipelines/build/dockerfiles/cilium-log-collector.Dockerfile:5
- This file is marked as autogenerated from .pipelines/build/dockerfiles/cilium-log-collector.Dockerfile.tmpl, but that template still uses fluent-bit v4.2.3-16; regeneration will undo this update. Please bump the template to v4.2.3-18 to keep generated output stable.
FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-18 as linux
bpf-prog/ipv6-hp-bpf/linux.Dockerfile:4
- The helper comment above the pinned Go builder image still says 1.26.7, but the actual image was bumped to 1.26.8-1. Updating the comment avoids confusion when re-resolving the digest later.
# IMG=mcr.microsoft.com/oss/go/microsoft/golang:1.26.7
# echo "${IMG}@$(skopeo inspect docker://${IMG} --format '{{.Digest}}')"
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26.8-1@sha256:2deab8229e22cf236b94e8f2a18fdca8b1c70009ab31660bfc400c4cd6922529 AS go
- Files reviewed: 9/9 changed files
- Comments generated: 0 new
- Review effort level: Lite
…3 updates Bumps the all-docker-dependencies group with 2 updates in the /.pipelines/build/dockerfiles directory: oss/v2/fluent/fluent-bit and windows/servercore. Bumps the all-docker-dependencies group with 1 update in the /azure-ip-masq-merger directory: oss/go/microsoft/golang. Bumps the all-docker-dependencies group with 1 update in the /azure-ipam directory: oss/go/microsoft/golang. Bumps the all-docker-dependencies group with 1 update in the /azure-iptables-monitor directory: oss/go/microsoft/golang. Bumps the all-docker-dependencies group with 1 update in the /bpf-prog/ipv6-hp-bpf directory: oss/go/microsoft/golang. Bumps the all-docker-dependencies group with 2 updates in the /cilium-log-collector directory: oss/v2/fluent/fluent-bit and oss/go/microsoft/golang. Bumps the all-docker-dependencies group with 1 update in the /cni directory: oss/go/microsoft/golang. Bumps the all-docker-dependencies group with 1 update in the /cns directory: oss/go/microsoft/golang. Updates `oss/v2/fluent/fluent-bit` from v4.2.3-16 to v4.2.3-18 Updates `windows/servercore` from `3a2a2fd` to `76cf422` Updates `oss/v2/fluent/fluent-bit` from v4.2.3-16 to v4.2.3-18 Updates `oss/go/microsoft/golang` from `829285f` to `9f6b5c4` Updates `oss/go/microsoft/golang` from `829285f` to `9f6b5c4` Updates `oss/go/microsoft/golang` from `829285f` to `9f6b5c4` Updates `oss/go/microsoft/golang` from 1.26.7 to 1.26.8-1 Updates `oss/go/microsoft/golang` from 1.26.7 to 1.26.8-1 Updates `oss/go/microsoft/golang` from 1.26.7 to 1.26.8-1 Updates `oss/go/microsoft/golang` from 1.26.7 to 1.26.8-1 Updates `oss/go/microsoft/golang` from 1.26.7 to 1.26.8-1 Updates `oss/go/microsoft/golang` from 1.26.7 to 1.26.8-1 Updates `oss/go/microsoft/golang` from 1.26.7 to 1.26.8-1 Updates `oss/v2/fluent/fluent-bit` from v4.2.3-16 to v4.2.3-18 Updates `oss/go/microsoft/golang` from `829285f` to `9f6b5c4` Updates `oss/v2/fluent/fluent-bit` from v4.2.3-16 to v4.2.3-18 Updates `oss/go/microsoft/golang` from `829285f` to `9f6b5c4` Updates `oss/go/microsoft/golang` from `829285f` to `9f6b5c4` --- updated-dependencies: - dependency-name: oss/go/microsoft/golang dependency-version: 1.26-azurelinux3.0 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26-azurelinux3.0 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26-azurelinux3.0 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26-azurelinux3.0 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26-azurelinux3.0 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26-azurelinux3.0 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26.8-1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26.8-1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26.8-1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26.8-1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26.8-1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26.8-1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-docker-dependencies - dependency-name: oss/go/microsoft/golang dependency-version: 1.26.8-1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-docker-dependencies - dependency-name: oss/v2/fluent/fluent-bit dependency-version: v4.2.3-18 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: oss/v2/fluent/fluent-bit dependency-version: v4.2.3-18 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: oss/v2/fluent/fluent-bit dependency-version: v4.2.3-18 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: oss/v2/fluent/fluent-bit dependency-version: v4.2.3-18 dependency-type: direct:production dependency-group: all-docker-dependencies - dependency-name: windows/servercore dependency-version: ltsc2022 dependency-type: direct:production dependency-group: all-docker-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
22d211b to
33b8323
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Five moderate review findings remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (4)
.pipelines/build/dockerfiles/cilium-log-collector.Dockerfile:5
- This rendered pipeline Dockerfile is sourced from
.pipelines/build/dockerfiles/cilium-log-collector.Dockerfile.tmpl, which still specifiesfluent-bit:v4.2.3-16. The nextmake dockerfilesrun will revert thisv4.2.3-18pin and fail the generated-file check; update the template and regenerate the artifact.
FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-18 as linux
bpf-prog/ipv6-hp-bpf/linux.Dockerfile:4
- This patch bump is not propagated to the other plain Go image consumers:
npm/linux.Dockerfileandnpm/windows.Dockerfilestill usemcr.microsoft.com/oss/go/microsoft/golang:1.26.7. Those are active NPM build paths, so the NPM artifacts will continue to be built with the old toolchain while this image uses 1.26.8-1; update both files consistently.
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26.8-1@sha256:2deab8229e22cf236b94e8f2a18fdca8b1c70009ab31660bfc400c4cd6922529 AS go
cilium-log-collector/Dockerfile:16
- This rendered Dockerfile is sourced from
cilium-log-collector/Dockerfile.tmpl, but that template still specifiesfluent-bit:v4.2.3-16. Runningmake dockerfileswill overwrite thisv4.2.3-18change and the base-image consistency workflow will fail; update the template and regenerate the rendered file.
FROM mcr.microsoft.com/oss/v2/fluent/fluent-bit:v4.2.3-18 as linux
cns/Dockerfile:8
- The generated pins here now use digest
9f6b5c4…, but.pipelines/build/scripts/install-go.shstill hardcodes the old Azure Linux fallback digest8f638b0…. If source-image parsing falls back, the pipeline installs a stale Go image; the Go version-check workflow also treats this digest mismatch as drift. UpdateDEFAULT_IMAGEto the new digest.
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26-azurelinux3.0@sha256:9f6b5c480db643ca536db638fc0346b5a8424fd738c916db5db6443e68ad130e AS go
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Lite
|
|
||
| # intermediate for win-ltsc2022 | ||
| FROM --platform=windows/${ARCH} mcr.microsoft.com/windows/servercore:ltsc2022@sha256:3a2a2fdfbae2f720f6fe26f2d7680146712ce330f605b02a61d624889735c72e as windows | ||
| FROM --platform=windows/${ARCH} mcr.microsoft.com/windows/servercore:ltsc2022@sha256:76cf422c98ca437b308374d0498280541fa42ac7061bb44015a6c8b70cf4db6a as windows |
| # IMG=mcr.microsoft.com/oss/go/microsoft/golang:1.26.7 | ||
| # echo "${IMG}@$(skopeo inspect docker://${IMG} --format '{{.Digest}}')" | ||
| FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26.7@sha256:be14ce4ce048adf5584ce3a0919d21987284e2235b6e7e9bb0e6a01133870be9 AS go | ||
| FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26.8-1@sha256:2deab8229e22cf236b94e8f2a18fdca8b1c70009ab31660bfc400c4cd6922529 AS go |
Warning
Cooldown could not be applied because no publication date was available from the registry.
Bumps the all-docker-dependencies group with 2 updates in the /.pipelines/build/dockerfiles directory: oss/v2/fluent/fluent-bit and windows/servercore.
Bumps the all-docker-dependencies group with 1 update in the /azure-ip-masq-merger directory: oss/go/microsoft/golang.
Bumps the all-docker-dependencies group with 1 update in the /azure-ipam directory: oss/go/microsoft/golang.
Bumps the all-docker-dependencies group with 1 update in the /azure-iptables-monitor directory: oss/go/microsoft/golang.
Bumps the all-docker-dependencies group with 1 update in the /bpf-prog/ipv6-hp-bpf directory: oss/go/microsoft/golang.
Bumps the all-docker-dependencies group with 2 updates in the /cilium-log-collector directory: oss/v2/fluent/fluent-bit and oss/go/microsoft/golang.
Bumps the all-docker-dependencies group with 1 update in the /cni directory: oss/go/microsoft/golang.
Bumps the all-docker-dependencies group with 1 update in the /cns directory: oss/go/microsoft/golang.
Updates
oss/v2/fluent/fluent-bitfrom v4.2.3-16 to v4.2.3-18Updates
windows/servercorefrom3a2a2fdto76cf422Updates
oss/v2/fluent/fluent-bitfrom v4.2.3-16 to v4.2.3-18Updates
oss/go/microsoft/golangfrom829285fto9f6b5c4Updates
oss/go/microsoft/golangfrom829285fto9f6b5c4Updates
oss/go/microsoft/golangfrom829285fto9f6b5c4Updates
oss/go/microsoft/golangfrom 1.26.7 to 1.26.8-1Updates
oss/go/microsoft/golangfrom 1.26.7 to 1.26.8-1Updates
oss/go/microsoft/golangfrom 1.26.7 to 1.26.8-1Updates
oss/go/microsoft/golangfrom 1.26.7 to 1.26.8-1Updates
oss/go/microsoft/golangfrom 1.26.7 to 1.26.8-1Updates
oss/go/microsoft/golangfrom 1.26.7 to 1.26.8-1Updates
oss/go/microsoft/golangfrom 1.26.7 to 1.26.8-1Updates
oss/v2/fluent/fluent-bitfrom v4.2.3-16 to v4.2.3-18Updates
oss/go/microsoft/golangfrom829285fto9f6b5c4Updates
oss/v2/fluent/fluent-bitfrom v4.2.3-16 to v4.2.3-18Updates
oss/go/microsoft/golangfrom829285fto9f6b5c4Updates
oss/go/microsoft/golangfrom829285fto9f6b5c4