feat(build): add PONv6 AKS cluster target - #4855
Open
Ashish Nair (nairashu) wants to merge 1 commit into
Open
Conversation
🌐 - Generated by Copilot
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The NAT Gateway ARM payload appears to use an incorrect property for IPv6 public IP attachment, which will likely break provisioning.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new AKS provisioning path under hack/aks/Makefile to enable repeatable dual-stack “PONv6” VNet Scale SWIFT BYO-CNI testing (static block pod IP allocation, StandardV2 NAT Gateway with IPv4/IPv6 Public IPs, and kube-proxy disabled).
Changes:
- Introduces dual-stack VNet/subnet provisioning target for SWIFT VNet Scale.
- Adds a StandardV2 NAT Gateway provisioning + subnet attachment target for dual-stack egress.
- Adds a new AKS create target for dual-stack VNet Scale SWIFT BYO-CNI without kube-proxy, using StaticBlock pod IP allocation.
File summaries
| File | Description |
|---|---|
hack/aks/Makefile |
Adds dual-stack network + StandardV2 NAT Gateway bring-up and a new dual-stack vnetscale SWIFT BYO-CNI no-kube-proxy cluster target. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+194
to
+197
| $(AZCLI) rest --method put \ | ||
| --url "https://management.azure.com$(NAT_GATEWAY_V2_ID)?api-version=2025-05-01" \ | ||
| --body '{"location":"$(REGION)","sku":{"name":"StandardV2"},"properties":{"publicIpAddresses":[{"id":"$(PUBLIC_IPv4)"}],"publicIpAddressesV6":[{"id":"$(PUBLIC_IPv6)"}]}}' \ | ||
| -o none |
Comment on lines
+188
to
+192
| $(AZCLI) network public-ip create -g $(GROUP) -l $(REGION) \ | ||
| --name $(IP_PREFIX)-$(CLUSTER)-v4 --allocation-method Static --sku StandardV2 \ | ||
| --tier Regional --version IPv4 --ip-tags $(IP_TAG) -o none | ||
| $(AZCLI) network public-ip create -g $(GROUP) -l $(REGION) \ | ||
| --name $(IP_PREFIX)-$(CLUSTER)-v6 --allocation-method Static --sku StandardV2 \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add a repeatable AKS make target for dual-stack PONv6 testing with static block pod IP allocation. The target provisions dual-stack node and pod subnets, configures a StandardV2 NAT Gateway with IPv4 and IPv6 public IPs, and creates a BYO CNI cluster without kube-proxy.
Issue Fixed:
None
Requirements:
Notes:
Validated with a GNU Make dry run of
vnetscale-dualstack-swift-byocni-nokubeproxy-upandgit diff --check. No Azure resources were created during validation.