cns: run stale-HNS cleanup for delegated-NIC Docker NCs - #4856
Draft
Paul Johnston (pjohnst5) wants to merge 1 commit into
Draft
cns: run stale-HNS cleanup for delegated-NIC Docker NCs#4856Paul Johnston (pjohnst5) wants to merge 1 commit into
Paul Johnston (pjohnst5) wants to merge 1 commit into
Conversation
Stale-HNS-resource cleanup on NC create previously ran only for the AzureContainerInstance NetworkContainerType. Delegated-NIC NCs on the Swift/BYON path arrive as ContainerType Docker, so leaked/orphaned delegated-NIC HNS networks (issue #4540) that strand a MAC were not cleaned for that path. Factor the enable/delegated-NIC gating and cleanup call into a shared helper (cleanupStaleHNSForDelegatedNIC) and add a dedicated cns.Docker branch that invokes it before saving NC goal state. The existing ACI branch keeps its control flow; only its inline cleanup block is replaced by the identical helper call. No APIPA gate is added: AKS has no ApipaNIC endpoints, so findStaleContainerByApipaIP no-ops on the passed local IP. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale-HNS-resource cleanup on NC create previously ran only for the AzureContainerInstance NetworkContainerType. Delegated-NIC NCs on the Swift/BYON path arrive as ContainerType Docker, so leaked/orphaned delegated-NIC HNS networks (issue #4540) that strand a MAC were not cleaned for that path.
Factor the enable/delegated-NIC gating and cleanup call into a shared helper (cleanupStaleHNSForDelegatedNIC) and add a dedicated cns.Docker branch that invokes it before saving NC goal state. The existing ACI branch keeps its control flow; only its inline cleanup block is replaced by the identical helper call. No APIPA gate is added: AKS has no ApipaNIC endpoints, so findStaleContainerByApipaIP no-ops on the passed local IP.