fix: avoid root-owned kubeconfig in LSG pipeline - #4857
Open
John Payne (jpayne3506) wants to merge 2 commits into
Open
fix: avoid root-owned kubeconfig in LSG pipeline#4857John Payne (jpayne3506) wants to merge 2 commits into
John Payne (jpayne3506) wants to merge 2 commits into
Conversation
Resolve the AKS version with the host Azure CLI so Make does not invoke the Docker default and create ~/.kube as root. Accept the minor-only orchestrator version returned by AKS node pool queries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 851648b1-fbe5-4653-a99c-d4400609bc9d
John Payne (jpayne3506)
requested a review
from Behzad Mirkhanzadeh (behzad-mir)
September 11, 2026 19:38
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
John Payne (jpayne3506)
September 11, 2026 19:39
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes address the kubeconfig issue and version-format compatibility without unresolved blocking concerns.
Pull request overview
Updates the LSG AKS pipeline to avoid root-owned kubeconfig creation and support flexible Kubernetes version responses.
Changes:
- Uses the host Azure CLI with LTS probing disabled.
- Accepts minor-only and patch Kubernetes versions.
- Validates the updated pipeline behavior.
File summaries
| File | Summary |
|---|---|
.pipelines/cni/lsg/lsg-cni-integration-template.yaml |
Updates version resolution and validation logic. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 851648b1-fbe5-4653-a99c-d4400609bc9d
Copilot started reviewing on behalf of
John Payne (jpayne3506)
September 11, 2026 19:50
View session
Vipul Singh (vipul-21)
approved these changes
Sep 11, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Confirm or revert the LTS behavior change and align the validation error message with accepted inputs.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
.pipelines/cni/lsg/lsg-cni-integration-template.yaml:89
- The validation now also accepts an exact minor-only response, but this failure text still says only
$K8S_VERSION.xis expected. A failed check for an invalid value would therefore report a condition that contradicts the acceptance logic; include both accepted forms in the message.
[[ "$ACTUAL_K8S_VERSION" == "$K8S_VERSION" || "$ACTUAL_K8S_VERSION" == "$K8S_VERSION".* ]] || {
echo "Expected Kubernetes $K8S_VERSION.x, got $ACTUAL_K8S_VERSION"
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
John Payne (jpayne3506)
enabled auto-merge
September 11, 2026 20:06
Camryn Lee (camrynl)
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
AZCLI=az) instead of the Makefile's Docker default1.35) and patch (1.35.x) node-pool orchestrator version responsesRoot cause
make -C ./hack/aks varsevaluatedLTS_ARGSusing the Makefile's default containerized Azure CLI. Docker bind-mounted the agent's.kubedirectory and created the previously absent directory as root. The later hostaz aks get-credentialscommand then failed withPermission denied: /home/cloudtest/.kube/config.Validation
K8S_VER=1.35.kubedirectory