test: wait for Linux datapath pods to be deleted - #4863
Open
Ethan Ermovick (Arleee1) wants to merge 1 commit into
Open
Ethan Ermovick (Arleee1) wants to merge 1 commit into
Ethan Ermovick (Arleee1) wants to merge 1 commit into
Conversation
Ethan Ermovick (Arleee1)
requested review from
a team,
Kshitija Murudi (kmurudi) and
sivakami-projects
as code owners
September 14, 2026 17:36
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Ethan Ermovick (Arleee1)
September 14, 2026 17:37
View session
Copilot started reviewing on behalf of
Ethan Ermovick (Arleee1)
September 14, 2026 17:49
View session
Ethan Ermovick (Arleee1)
force-pushed
the
eermovick/datapath-wait-for-pod-cleanup
branch
from
September 14, 2026 17:57
9adcd26 to
d54e7ab
Compare
Ethan Ermovick (Arleee1)
marked this pull request as draft
September 14, 2026 18:12
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Ethan Ermovick (Arleee1)
force-pushed
the
eermovick/datapath-wait-for-pod-cleanup
branch
from
September 14, 2026 19:04
f834179 to
935bc36
Compare
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 4863 in repo Azure/azure-container-networking |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Ethan Ermovick (Arleee1)
September 15, 2026 14:15
View session
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Update the stale install-go.sh fallback digest to match the refreshed Go pin.
Review details
Suppressed comments (1)
cns/Dockerfile:8
- This refresh updates the generated Go pin to
3c78e..., but.pipelines/build/scripts/install-go.shstill falls back to the old8f638...digest. The Go-version workflow explicitly treats that mismatch as digest drift, and builds that cannot resolve a component Dockerfile will install the stale toolchain; updateDEFAULT_IMAGEin the same refresh.
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang:1.26-azurelinux3.0@sha256:3c78e9858004d1c43aea08829306c76c3bf870c26b98c8c07ea6ca74c54787cf AS go
- Files reviewed: 13/13 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Consecutive IPv6 and IPv4 datapath tests reuse Goldpinger labels. Terminating pods left by cleanup can satisfy the next invocation's readiness check, then cause
Less than 2 pods on node.Wait for both the deployment's and DaemonSet's pod selectors to become empty after the existing deletion calls, using
WaitForPodsDelete. Report wait failures witht.Error. Both selectors are needed when-podNameis customized.Readiness checks, RBAC cleanup, and timeouts are unchanged.
Issue Fixed:
Fixes #4864
Requirements:
Notes:
Compilation-only check passed; no tests were selected.