fix: [NPM] account for default-drop ACLs in Windows tests - #4865
Queued
Isaiah Raya (rayaisaiah) wants to merge 1 commit into
Queued
Isaiah Raya (rayaisaiah) wants to merge 1 commit into
Isaiah Raya (rayaisaiah) wants to merge 1 commit into
Conversation
Include the final default-drop ACL in expected totals and assert its direction while preserving the existing rule assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34a65643-fec6-4741-af85-12ca9eeca2ba
Isaiah Raya (rayaisaiah)
requested review from
Mathew Merrick (matmerr)
and
a lite review from Copilot
September 14, 2026 20:47
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Isaiah Raya (rayaisaiah)
September 14, 2026 20:48
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain, and the changes are limited to test expectations and assertions.
Pull request overview
Updates Windows NPM Lite translation tests to account for and verify final default-drop ACLs.
Changes:
- Corrects expected ACL counts.
- Adds assertions for default-drop ACL direction and placement.
- Makes no production code changes.
File summaries
| File | Summary |
|---|---|
npm/pkg/controlplane/translation/translatePolicy_windows_test.go |
Strengthens four Windows translation tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Mathew Merrick (matmerr)
approved these changes
Sep 14, 2026
Isaiah Raya (rayaisaiah)
enabled auto-merge
September 14, 2026 21:12
Isaiah Raya (rayaisaiah)
added this pull request to the merge queue
Sep 14, 2026
Any commits made after this event will not be merged.
Isaiah Raya (rayaisaiah)
removed this pull request from the merge queue due to a manual request
Sep 14, 2026
Isaiah Raya (rayaisaiah)
added this pull request to the merge queue
Sep 14, 2026
Any commits made after this event will not be merged.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2026
Isaiah Raya (rayaisaiah)
added this pull request to the merge queue
Sep 15, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Four NPM Lite Windows translation tests omitted the final default-drop ACL from their expected totals.
Update the expected counts and explicitly verify the final default-drop ACL and its direction. Existing allow-rule, exception-rule, priority, port-scope, and deduplication assertions remain unchanged.
Issue Fixed:
Incorrect ACL-count expectations in the Windows translation tests.
Related to #4823.
Requirements:
Notes: