Merged
Conversation
Member
|
Would it be worth pulling in #435 first? |
Collaborator
Author
|
@cgillum: I considered it, but I have a few questions about that change (would like to see an example of special characters that cause the API to fail, and I'd also make sure that the quoting is not accidentally a breaking change) so I think it'll take just a bit more time. In general, I want to step in through the code in an E2E execution to make sure the quoting is working as expected. Since we're a bit overdue for BluePrint support in the new Python programming model, I'd love to get this out for now. |
nytian
approved these changes
May 1, 2023
cgillum
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in title, routine PR