Fabric Mirror Settings API changes#40348
Conversation
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they may.Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
| } | ||
| } | ||
| }, | ||
| "201": { |
There was a problem hiding this comment.
it is a long running operation, can you also provide 202 response
There was a problem hiding this comment.
Hi @judyzhu10 , I have added the 202 response. Can you please check, verify and if seems correct then resolve the comment. Thanks
|
Finally, please check whether the Swagger generated in openapi.json meets your expectations. |
mohitsinha-ms
force-pushed
the
fabric_changes
branch
from
151ebc6 to
8eadf7d
Compare
| using Azure.ResourceManager; | ||
| using TypeSpec.OpenAPI; | ||
|
|
||
| @versioned(Versions) |
There was a problem hiding this comment.
Removed @versioned(Versions) from this file. It is already declared in main.tsp (line 43).
| } | ||
|
|
||
| #suppress "@azure-tools/typespec-azure-resource-manager/no-resource-delete-operation" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details" | ||
| @armResourceOperations |
There was a problem hiding this comment.
Just add @added() above the interface; there’s no need to add a version annotation to each get/create/list operation.
There was a problem hiding this comment.
Done — moved @added(Versions.v2025_12_01_preview) to the interface level and removed it from all three individual operations (get, createOrUpdate, listByServer).
|
|
||
| @doc("List Fabric Mirroring settings by server.") | ||
| @added(Versions.v2025_12_01_preview) | ||
| @operationId("FabricMirroringSettings_ListByServer") |
There was a problem hiding this comment.
Default template list is a pageable API. Can you check whether your API supports pagination?
There was a problem hiding this comment.
Aakarshit confirmed that we are not supporting pagination. There would always be a single record.
There was a problem hiding this comment.
Hi @judyzhu10, checked with the team — our API does not support pagination. There will always be a single record ("Default") per server.
Updated the list operation from ArmResourceListByParent to Azure.ResourceManager.Legacy.ArmListSinglePageByParent, which removes x-ms-pageable from the generated OpenAPI while keeping the same response shape. Please review.
mohitsinha-ms
force-pushed
the
fabric_changes
branch
from
f482d25 to
0c73d81
Compare
judyzhu10
force-pushed
the
mysql/2025-12-01
branch
2 times, most recently
from
955db16 to
49848ea
Compare
Adds a new FabricMirroringSettings singleton proxy resource under MySQL FlexibleServers with GET, PUT (LRO), and List operations. Includes TypeSpec source, examples, and addresses all review comments.
mohitsinha-ms
force-pushed
the
fabric_changes
branch
from
0c73d81 to
400b958
Compare
Adds a new FabricMirroringSettings singleton proxy resource under MySQL FlexibleServers with GET, PUT (LRO), and List operations. Includes TypeSpec source, examples, and addresses all review comments. Co-authored-by: Mohit Sinha <mohitsinha@microsoft.com>
Adds a new FabricMirroringSettings singleton proxy resource under MySQL FlexibleServers with GET, PUT (LRO), and List operations. Includes TypeSpec source, examples, and addresses all review comments. Co-authored-by: Mohit Sinha <mohitsinha@microsoft.com>
3 participants
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.