Skip to content

Fix chat read receipt for sender rejoin#6058

Open
kpavan1966 wants to merge 2 commits into
Azure:mainfrom
kpavan1966:users/pkanukollu/fix-read-receipt-sender-rejoin
Open

Fix chat read receipt for sender rejoin#6058
kpavan1966 wants to merge 2 commits into
Azure:mainfrom
kpavan1966:users/pkanukollu/fix-read-receipt-sender-rejoin

Conversation

@kpavan1966
Copy link
Copy Markdown

What

Fixes chat read receipt state so the current user's own read receipt does not advance latestReadTime after the sender rejoins a thread.

Why

ChatContext.addReadReceipt was comparing CommunicationIdentifier objects by reference. The same ACS user can be represented by different object instances, so the current user's own read receipt was not filtered out. After the sender rejoined and opened the thread, their own read receipt could make their previously sent message appear as seen even when the recipient never viewed it.

How

Compare flattened communication identifiers instead of object references before updating read receipt state.

Validation

  • rush build -t @internal/chat-stateful-client
  • rushx test
  • rushx lint

Prevent the current user's own read receipt from advancing latestReadTime, which is used to mark sent messages as seen.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kpavan1966 kpavan1966 requested review from a team as code owners May 27, 2026 00:26
@kpavan1966
Copy link
Copy Markdown
Author

kpavan1966 commented May 27, 2026 via email

@kpavan1966
Copy link
Copy Markdown
Author

kpavan1966 commented May 27, 2026 via email

@pohtsng pohtsng self-requested a review May 27, 2026 16:54
@pohtsng pohtsng enabled auto-merge (squash) May 28, 2026 04:17
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
auto-merge was automatically disabled May 28, 2026 21:28

Head branch was pushed to by a user without write access

@kpavan1966 kpavan1966 requested review from a team as code owners May 28, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants