Skip to content

refactor: make GetVMSize function public #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tallaxes merged 1 commit into from
Jul 17, 2025
Merged

refactor: make GetVMSize function public #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sku.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ func (s *SKU) GetSize() string {
}

func (s *SKU) GetVMSize() (*VMSizeType, error) {
return getVMSize(s.GetSize())
return GetVMSize(s.GetSize())
}

// GetLocation returns the location for a given SKU.
Expand Down
4 changes: 2 additions & 2 deletions vmsize.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ func parseVMSize(vmSizeName string) ([]string, error) {
return parts, nil
}

// getVMSize is a helper function used by GetVMSize() in sku.go
func getVMSize(vmSizeName string) (*VMSizeType, error) {
// GetVMSize is a helper function used by GetVMSize() in sku.go
func GetVMSize(vmSizeName string) (*VMSizeType, error) {
vmSize := VMSizeType{}

parts, err := parseVMSize(vmSizeName)
Expand Down
6 changes: 3 additions & 3 deletions vmsize_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,11 @@ var testCases = []struct {
},
}

// Test_getSize tests the getSize() function.
func Test_getVMsize(t *testing.T) {
// Test_GetVMSize tests the GetVMSize() function.
func Test_GetVMSize(t *testing.T) {
a := assert.New(t)
for _, test := range testCases {
vmSize, err := getVMSize(test.size)
vmSize, err := GetVMSize(test.size)
a.Equal(test.err, err)
if err != nil {
continue
Expand Down