Skip to content

Move ZMQ socket bind to poll thread to prevent blocking #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ypcisco wants to merge 2 commits into
base: 202506
Choose a base branch
from
Open

Move ZMQ socket bind to poll thread to prevent blocking #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4cd560
Move ZMQ socket bind to poll thread to prevent blocking
ypcisco Feb 2, 2026
eed0ae8
Corrected Logging
ypcisco Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions common/zmqserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,7 @@ void ZmqServer::bind()
zmq_setsockopt(m_socket, ZMQ_BINDTODEVICE, m_vrf.c_str(), m_vrf.length());
}

int rc = zmq_bind(m_socket, m_endpoint.c_str());
if (rc != 0)
{
SWSS_LOG_THROW("zmq_bind failed on endpoint: %s, zmqerrno: %d",
m_endpoint.c_str(),
zmq_errno());
}

SWSS_LOG_DEBUG("ZmqServer bind to endpoint: %s", m_endpoint.c_str());
SWSS_LOG_NOTICE("ZmqServer socket created, actual bind to %s will occur in mqPollThread to prevent blocking", m_endpoint.c_str());

startMqPollThread();
}
Expand Down Expand Up @@ -153,6 +145,14 @@ void ZmqServer::mqPollThread()
SWSS_LOG_ENTER();
SWSS_LOG_NOTICE("mqPollThread begin");

SWSS_LOG_NOTICE("Attempting to bind to zmq endpoint: %s", m_endpoint.c_str());
if (zmq_bind(m_socket, m_endpoint.c_str()) != 0)
{
SWSS_LOG_THROW("zmq_bind failed on endpoint: %s, zmqerrno: %d",
m_endpoint.c_str(),
zmq_errno());
}

// zmq_poll will use less CPU
zmq_pollitem_t poll_item;
poll_item.fd = 0;
Expand Down