Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ firewall_config_list = [
source_addresses = ["*"]
target_fqdns = ["*.azure.com", "*.azure.net",
"*.windows.net", "*.azurecr.io", "*.ubuntu.com", "AzureKubernetesService",
"mcr-0001.mcr-msedge.net", "*.microsoft.com",
"mcr-0001.mcr-msedge.net", "*.microsoft.com", "mcr.microsoft.com", "*.mcr.microsoft.com",
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FQDN mcr.microsoft.com is redundant because it's already covered by the existing *.microsoft.com wildcard pattern. The wildcard *.microsoft.com matches any subdomain of microsoft.com, including mcr.microsoft.com. You can remove mcr.microsoft.com from this list while keeping *.mcr.microsoft.com to allow subdomains of mcr.microsoft.com (e.g., <region>.mcr.microsoft.com).

Suggested change
"mcr-0001.mcr-msedge.net", "*.microsoft.com", "mcr.microsoft.com", "*.mcr.microsoft.com",
"mcr-0001.mcr-msedge.net", "*.microsoft.com", "*.mcr.microsoft.com",

Copilot uses AI. Check for mistakes.
"*.microsoftonline.com", "*.microsoftonline.co", "*.azureedge.net",
"packages.aks.azure.com"]
protocols = [
Expand Down