Validate aks_name length to prevent cluster creation failure#1056
Open
Validate aks_name length to prevent cluster creation failure#1056
Conversation
liyu-ma
force-pushed
the
len-validation-aksname
branch
from
187356d to
46c75c2
Compare
liyu-ma
requested review from
alyssa1303,
anson627,
sumanthreddy29,
vittoriasalim and
xinWeiWei24
as code owners
liyu-ma
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions validation in the Terraform PR workflow to fail fast when an Azure aks_name is too long and would cause AKS node resource group naming to exceed Azure’s 80-character limit.
Changes:
- Introduces an Azure-only workflow step to parse
aks_namefrom the scenario.tfvarsfile. - Fails the job if any detected
aks_nameexceeds a configured maximum length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AKS creates a node resource group in the background for each aks cluster. The node RG names follows format
MC_{cluster_rg}_{aks_name}_{region}. This name is allowed at 80 chars max length. Place a validation step to fail fast ifaks_nameis long and potentially fail cluster creation.How it looks like when validation failed:
