[msal-node-extensions]: Add electron webpack sample#4034
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
|
Can you share the changes made in your fork of bindings? |
Sure thing, I want to move the changes to a fork under AzureAD, so I can update the pull request. |
jasonnutter
left a comment
There was a problem hiding this comment.
Looks good! We should setup some time to talk about how we want to approach your fork of bindings long-term, but this is good for now.
derisen
left a comment
There was a problem hiding this comment.
LGTM! Apologies for delay, getting node-gyp to work is painful.. Left a minor comment.
| "dependencies": { | ||
| "@azure/msal-common": "^5.0.0", | ||
| "bindings": "^1.5.0", | ||
| "bindings": "git://github.com/samuelkubai/node-bindings.git#v1.6.0", |
There was a problem hiding this comment.
Did we follow up on creating an azure repo for this?
There was a problem hiding this comment.
Yes we did, we realized it would take a lot longer to process and thus decided to go on with this setup for the time being as we research on how best to switch to a repo under AzureAD
sameerag
left a comment
There was a problem hiding this comment.
Approved. I have a concern merging this - please ensure that your fork is covered under open source licensing so we can proceed with the merge.
This pull request aims to fix the webpack compatibility issue by doing the following:-
Note:
The created fork can be found here