Skip to content

[BOUNTY] chore: replace legacy deps - ng5-slider + angular-instantsearch + moment.js to date-fns v3 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cycy701 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BOUNTY] chore: replace legacy deps - ng5-slider + angular-instantsearch + moment.js to date-fns v3 #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 43 additions & 60 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
},
"private": true,
"dependencies": {
"@angular-slider/ngx-slider": "^2.0.3",
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

Is @angular-slider/ngx-slider version 2.0.3 compatible with Angular 15?

💡 Result:

No, @angular-slider/ngx-slider version 2.0.3 is not compatible with Angular 15 [1][2][3]. Version 2.0.3 of @angular-slider/ngx-slider was released in February 2022 and was designed to support Angular versions 6 through 12 [1][2][3]. It does not include support for Angular 15 [1][2][3]. If you are using Angular 15, you should use a version of the package that explicitly supports it, such as version 15.x.x of the @angular-slider/ngx-slider package [1][2][3]. Alternatively, many developers facing compatibility issues with the original package have migrated to the community-maintained package ngx-slider-v2, which provides specific versions for Angular 15 [4][5].

Citations:

Upgrade @angular-slider/ngx-slider to a version compatible with Angular 15.

@angular-slider/ngx-slider v2.0.3 only supports Angular 6–12 and is incompatible with Angular 15. Use version 15.x.x or later of the package, or migrate to ngx-slider-v2 if needed.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 21, The dependency "`@angular-slider/ngx-slider`" in
package.json is pinned to v2.0.3 which is incompatible with Angular 15; update
the package entry for "`@angular-slider/ngx-slider`" to a 15.x.x (or later)
compatible release (e.g., "^15.0.0") or replace it with the recommended
"ngx-slider-v2" package if you prefer the newer maintained fork, then run your
package manager (npm/yarn) to reinstall and run the app's test/build to verify
compatibility.

"@angular/common": "^15.0.0",
"@angular/core": "^15.0.0",
"@angular/forms": "^15.0.0",
Expand Down Expand Up @@ -54,13 +55,11 @@
"chart.js": "^4.1.1",
"cordova-plugin-file": "^7.0.0",
"cordova-plugin-nativestorage": "^2.3.2",
"date-fns": "^2.29.3",
"date-fns": "^3.6.0",
"file-saver": "^2.0.5",
"ion2-calendar": "^3.5.0",
"ionicons": "^6.0.3",
"mixpanel-browser": "^2.45.0",
"moment": "^2.30.1",
"ng5-slider": "^1.2.6",
"rxjs": "~7.5.0",
"tslib": "^2.3.0",
"zone.js": "~0.11.4"
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/age-refinement-list/age-refinement-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
{{ value.upper | age }}
</ion-label>

<ng5-slider [(value)]="value.lower" [(highValue)]="value.upper"
<ngx-slider [(value)]="value.lower" [(highValue)]="value.upper"
(userChangeEnd)="handleChange()"
(userChange)="setLabel()" [options]="options"></ng5-slider>
(userChange)="setLabel()" [options]="options"></ngx-slider>
<!--
<ion-range debounce="500" dualKnobs="true" (ionChange)="handleChange($event)"
[value]="value"
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/age-refinement-list/age-refinement-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { connectRange } from 'instantsearch.js/es/connectors';
import { RangeRenderState } from 'instantsearch.js/es/connectors/range/connectRange';
import { BaseWidget, NgAisIndex, NgAisInstantSearch } from 'angular-instantsearch';
import { parseNumberInput, noop } from 'angular-instantsearch/esm2015/utils';
import { Options } from 'ng5-slider';
import { Options } from '@angular-slider/ngx-slider';


@Component({
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/age-refinement-list/age-refinement-list.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { Ng5SliderModule } from 'ng5-slider';
import { NgxSliderModule } from '@angular-slider/ngx-slider';
import { FormsModule } from '@angular/forms';
import { NgAisModule } from 'angular-instantsearch';
import { IonicModule } from '@ionic/angular';
Expand All @@ -18,7 +18,7 @@ import { AgeRefinementListComponent } from './age-refinement-list.component';
CommonModule,
FormsModule,
PipesModule,
Ng5SliderModule,
NgxSliderModule,
],
exports: [
AgeRefinementListComponent
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/range-refinement-list/range-refinement-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
{{ value.upper | age }}
</ion-label>

<ng5-slider [(value)]="value.lower" [(highValue)]="value.upper"
<ngx-slider [(value)]="value.lower" [(highValue)]="value.upper"
(userChangeEnd)="handleChange()"
(userChange)="setLabel()" [options]="options"></ng5-slider>
(userChange)="setLabel()" [options]="options"></ngx-slider>
<!--
<ion-range debounce="500" dualKnobs="true" (ionChange)="handleChange($event)"
[value]="value"
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/range-refinement-list/range-refinement-list.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { FormsModule } from "@angular/forms";
import { RangeRefinementComponent } from './range-refinement-list';

import { NgAisModule } from 'angular-instantsearch';
import { Ng5SliderModule } from 'ng5-slider';
import { NgxSliderModule } from '@angular-slider/ngx-slider';

import { PipesModule } from '../../pipes/pipes.module';

Expand All @@ -21,7 +21,7 @@ import { PipesModule } from '../../pipes/pipes.module';
CommonModule,
FormsModule,
PipesModule,
Ng5SliderModule,
NgxSliderModule,
],
exports: [
RangeRefinementComponent
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/range-refinement-list/range-refinement-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { connectRange } from 'instantsearch.js/es/connectors';
import { RangeRenderState } from 'instantsearch.js/es/connectors/range/connectRange';
import { BaseWidget, NgAisIndex, NgAisInstantSearch } from 'angular-instantsearch';
import { parseNumberInput, noop } from 'angular-instantsearch/esm2015/utils';
import { Options } from 'ng5-slider';
import { Options } from '@angular-slider/ngx-slider';


@Component({
Expand Down