feat: implement batch_transfer, batch_mint, batch_approve (#160)#213
Open
paulinaapeh8 wants to merge 2 commits into
Open
feat: implement batch_transfer, batch_mint, batch_approve (#160)#213paulinaapeh8 wants to merge 2 commits into
paulinaapeh8 wants to merge 2 commits into
Conversation
) - Add MAX_BATCH_SIZE=50 constant with BatchTooLarge/BatchEmpty errors - batch_mint: validate all entries fail-fast, emit batch event, atomic - batch_transfer: pre-validate total, handle self-transfer edge case - batch_approve: approve multiple spenders atomically, zero revokes - Add emit_batch_transfer, emit_batch_mint, emit_batch_approve events - Add 24 comprehensive tests covering empty, single, multi, max size, too large, invalid amounts, paused state, overflow, self-transfer, zero-amount revoke - SDK: add batchTransfer(), batchApprove(), BatchTransferRecipient, BatchApproveSpender types; export from index.ts - Fix pre-existing compile errors: FeeExemption u8->u32, duplicate private helper names, ledger().set() API, missing Ledger trait imports
|
@paulinaapeh8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Related Issue
Closes #
Changes Made
Testing
How has this been tested?
cargo test)npm run buildinsdk/)Test commands run:
Checklist
feature/<issue-number>-<description>Drips.network Contributor Info
Screenshots (if applicable)
Closes #160