Skip to content

[Chore] 분실물 레거시 코드 제거#1363

Open
kongwoojin wants to merge 3 commits intodevelopfrom
chore/#1362-remove-legacy-lostandfound
Open

[Chore] 분실물 레거시 코드 제거#1363
kongwoojin wants to merge 3 commits intodevelopfrom
chore/#1362-remove-legacy-lostandfound

Conversation

@kongwoojin
Copy link
Member

@kongwoojin kongwoojin commented Mar 16, 2026

PR 개요

PR 체크리스트

  • Code convention을 잘 지켰나요?
  • Lint check를 수행하였나요?
  • Assignees를 추가했나요?

작업사항

  • 버그 수정
  • 신규 기능
  • 코드 스타일 수정 (포맷팅 등)
  • 리팩토링 (기능 수정 X, API 수정 X)
  • 기타

작업사항의 상세한 설명

  • 분실물 레거시 코드를 제거했습니다.
  • AGENTS.md를 업데이트 했습니다.

논의 사항

스크린샷

추가내용

  • develop, sprint 브랜치를 향하고 있습니다
  • production 브랜치를 향하고 있습니다

Summary by CodeRabbit

Release Notes

  • 리팩토링
    • 기사 모듈에서 분실물 찾기 기능이 제거되었습니다.
    • 관련 사용자 인터페이스 컴포넌트가 정리되었습니다.
    • 네비게이션 경로와 관련 리소스가 간소화되었습니다.

@kongwoojin kongwoojin self-assigned this Mar 16, 2026
@kongwoojin kongwoojin requested a review from a team as a code owner March 16, 2026 05:15
@github-actions github-actions bot added the chore label Mar 16, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Walkthrough

이 PR은 아티클 모듈에서 Lost & Found 기능을 제거합니다. 여러 UI 컴포넌트, 네비게이션 프래그먼트, 도메인 모델, 리소스 파일, 그리고 문서가 함께 삭제 및 수정되었습니다.

Changes

Cohort / File(s) Summary
Documentation & Architecture
feature/article/AGENTS.md
Lost & Found 기능이 아티클 모듈 구조, 보드 타입 참조 테이블, 마이그레이션 노트에서 제거됨. 문서가 Notices, Keywords, Search만 포함하도록 단순화됨.
Activity & Navigation Logic
feature/article/src/main/java/in/koreatech/koin/feature/article/ArticleActivity.kt, feature/article/src/main/res/navigation/nav_graph_article.xml
세 개의 Lost & Found 관련 프래그먼트가 네비게이션 그래프에서 제거됨 (WriteLostFragment, WriteFoundFragment, DetailFragment). setNavigationGraph() 함수가 파라미터 제거되고 startBoard가 하드코딩됨. BUNDLE_ARTICLE_EXTRA_KEY 상수 제거.
Toolbar & Model Updates
feature/article/src/main/java/in/koreatech/koin/feature/article/model/ArticleToolbarState.kt
ArticleToolbarState 열거형에서 두 개의 Lost & Found 관련 상수 제거 (ARTICLE_LOSTANDFOUND_LOST_ITEM, ARTICLE_LOSTANDFOUND_FOUND_ITEM).
UI Components
feature/article/src/main/java/in/koreatech/koin/feature/article/component/Dropdown.kt, feature/article/src/main/java/in/koreatech/koin/feature/article/component/HotArticle.kt, feature/article/src/main/java/in/koreatech/koin/feature/article/component/KeywordChipGroup.kt, feature/article/src/main/java/in/koreatech/koin/feature/article/component/LoadingDialog.kt
네 개의 Compose UI 컴포넌트 파일이 완전히 삭제됨. 드롭다운, 핫 아티클, 키워드 칩 그룹, 로딩 다이얼로그 관련 공개 API 제거.
String Resources
feature/article/src/main/res/values/strings.xml
Lost & Found 관련 일곱 개의 문자열 리소스 제거 (article_lost_and_found, fab_write, fab_found, fab_lost, navigation titles, report string).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

koin project

Suggested reviewers

  • TTRR1007
  • JaeYoung290
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 분실물 레거시 코드 제거라는 주요 변경사항을 명확하게 요약하고 있으며, 전체 변경사항과 일치합니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/#1362-remove-legacy-lostandfound
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@bcsd-b-bot bcsd-b-bot bot added the ci:passed label Mar 16, 2026
@kongwoojin
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
feature/article/src/main/java/in/koreatech/koin/feature/article/ArticleActivity.kt (1)

155-158: ⚠️ Potential issue | 🟡 Minor

NAVIGATE_ACTION 상수 제거 필요

Lost & Found 제거 후 NAVIGATE_ACTION 상수가 더 이상 사용되지 않습니다. 함께 제거하세요.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@feature/article/src/main/java/in/koreatech/koin/feature/article/ArticleActivity.kt`
around lines 155 - 158, ArticleActivity의 companion object에 선언된 사용되지 않는 상수
NAVIGATE_ACTION을 제거하세요: companion object 내에서 NAVIGATE_ACTION만 삭제하고 START_BOARD는
그대로 유지하여 불필요한 상수 정의를 정리합니다 (대상 식별자: NAVIGATE_ACTION in ArticleActivity companion
object).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In
`@feature/article/src/main/java/in/koreatech/koin/feature/article/ArticleActivity.kt`:
- Around line 155-158: ArticleActivity의 companion object에 선언된 사용되지 않는 상수
NAVIGATE_ACTION을 제거하세요: companion object 내에서 NAVIGATE_ACTION만 삭제하고 START_BOARD는
그대로 유지하여 불필요한 상수 정의를 정리합니다 (대상 식별자: NAVIGATE_ACTION in ArticleActivity companion
object).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1a4f4242-4cc3-4e74-8d31-7d869443b51a

📥 Commits

Reviewing files that changed from the base of the PR and between 0708f93 and 9f1bb2e.

📒 Files selected for processing (9)
  • feature/article/AGENTS.md
  • feature/article/src/main/java/in/koreatech/koin/feature/article/ArticleActivity.kt
  • feature/article/src/main/java/in/koreatech/koin/feature/article/component/Dropdown.kt
  • feature/article/src/main/java/in/koreatech/koin/feature/article/component/HotArticle.kt
  • feature/article/src/main/java/in/koreatech/koin/feature/article/component/KeywordChipGroup.kt
  • feature/article/src/main/java/in/koreatech/koin/feature/article/component/LoadingDialog.kt
  • feature/article/src/main/java/in/koreatech/koin/feature/article/model/ArticleToolbarState.kt
  • feature/article/src/main/res/navigation/nav_graph_article.xml
  • feature/article/src/main/res/values/strings.xml
💤 Files with no reviewable changes (6)
  • feature/article/src/main/java/in/koreatech/koin/feature/article/component/Dropdown.kt
  • feature/article/src/main/res/values/strings.xml
  • feature/article/src/main/res/navigation/nav_graph_article.xml
  • feature/article/src/main/java/in/koreatech/koin/feature/article/component/HotArticle.kt
  • feature/article/src/main/java/in/koreatech/koin/feature/article/component/LoadingDialog.kt
  • feature/article/src/main/java/in/koreatech/koin/feature/article/component/KeywordChipGroup.kt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant