Skip to content

fix: 콜밴 게시글 조회 시 소프트 딜리트 여부 고려하여 참여 여부 상태 결정#2179

Merged
dh2906 merged 1 commit intodevelopfrom
fix/2178-callvan-soft-delete-join-state
Mar 16, 2026
Merged

fix: 콜밴 게시글 조회 시 소프트 딜리트 여부 고려하여 참여 여부 상태 결정#2179
dh2906 merged 1 commit intodevelopfrom
fix/2178-callvan-soft-delete-join-state

Conversation

@dh2906
Copy link
Contributor

@dh2906 dh2906 commented Mar 16, 2026

🔍 개요

  • 콜밴 게시글 목록 조회에서 soft-delete된 참여 이력이 참여 여부 계산에 포함되어, 탈퇴한 사용자가 계속 참여 중으로 보이던 문제를 수정한다.

🚀 주요 변경 내용

  • CallvanParticipantRepository의 목록 참여 조회 메서드를 findAllByMemberIdAndPostIdInAndIsDeletedFalse(...)로 변경했습니다.

  • CallvanPostQueryService에서 게시글 목록의 joinedPostIds 계산 시 soft-delete되지 않은 참여 이력만 반영하도록 수정했습니다.


💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Enhanced data accuracy by ensuring logically deleted participant records are consistently excluded from queries, improving the reliability of participant information across the platform.

@dh2906 dh2906 self-assigned this Mar 16, 2026
@dh2906 dh2906 added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Mar 16, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 590cb9f0-d114-4635-952f-79d82d56fb6e

📥 Commits

Reviewing files that changed from the base of the PR and between 2836447 and a20ef3e.

📒 Files selected for processing (2)
  • src/main/java/in/koreatech/koin/domain/callvan/repository/CallvanParticipantRepository.java
  • src/main/java/in/koreatech/koin/domain/callvan/service/CallvanPostQueryService.java

📝 Walkthrough

Walkthrough

This change updates the CallvanParticipant repository method to filter out soft-deleted records by renaming findAllByMemberIdAndPostIdIn to findAllByMemberIdAndPostIdInAndIsDeletedFalse and updates the corresponding service call accordingly.

Changes

Cohort / File(s) Summary
Soft Delete Filter Implementation
src/main/java/in/koreatech/koin/domain/callvan/repository/CallvanParticipantRepository.java, src/main/java/in/koreatech/koin/domain/callvan/service/CallvanPostQueryService.java
Updated repository method signature to exclude logically deleted participants by adding IsDeletedFalse filter condition, and updated service layer to call the new method signature when retrieving joined post IDs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Soft whispers of deletion fade from sight,
A filter applied with logical delight,
The callvan participants rest in peace,
No ghost records causing unease! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the soft-delete consideration when determining participation status in callvan post listings.
Linked Issues check ✅ Passed The PR addresses the linked issue #2178 by ensuring soft-deleted participation records are excluded from join state calculations in callvan post queries.
Out of Scope Changes check ✅ Passed All changes are directly related to the objective: updating repository method to filter out soft-deleted records and updating the query service accordingly.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/2178-callvan-soft-delete-join-state
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@DHkimgit DHkimgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 !!

@github-actions
Copy link

Unit Test Results

690 tests   687 ✔️  1m 22s ⏱️
169 suites      3 💤
169 files        0

Results for commit a20ef3e.

@dh2906 dh2906 merged commit 9dbfd9c into develop Mar 16, 2026
11 checks passed
@dh2906 dh2906 deleted the fix/2178-callvan-soft-delete-join-state branch March 16, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

버그 정상적으로 동작하지 않는 문제상황입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[캠퍼스] 콜밴팟 합류&탈퇴 시 소프트 딜리트 고려

2 participants