Add tilt/orientation to MANUAL pre_designed arrangement - #169
Open
j-c-cook wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Depends on #163. This PR targets
144-tilted-borehole-design-algorithmsrather thandevelop.Merge intent: I am proposing that this work lands into #163's branch before #163 itself merges into
develop, so that the combined tilt-design + tilt-MANUAL contribution reachesdevelopas a single coherent feature. This avoids a follow-up rebase on my end.Extends the MANUAL
pre_designedarrangement to accept optional per-boreholetiltsandorientationsarrays, complementing the sizing-search tilt support introduced in #163. Together, the two PRs cover both designing tilted fields and evaluating already-sized, geometrically-specified tilted fields.Checklist