Repository navigation
fix(playback): recognize VR180 tile, fisheye and right-eye-first metadata (#172) - #222
Merged
Merged
Conversation
…data (#172) Parse container projection and stereo metadata according to FFmpeg specifications: - Add VideoProjection::EquirectangularTile with fixed-point 0.32 bounds, resolving tiles with ~50% horizontal coverage to VR180 (mono/SBS) and ~100% to 360°. - Map AV_SPHERICAL_FISHEYE to Fisheye190. - Map AV_STEREO3D_FLAG_INVERT with SBS to SideBySideRight and with TB to TopBottomRight. - Extract initial projection orientation (yaw, pitch, roll) from AVSphericalMapping and carry it to the native renderer via consume_initial_orientation, rotating the initial scene view. Closes #172
…e unaligned reads (#172)
Owner
Author
PR Review & Fixes SummaryAll review findings from the initial inspection have been resolved in commit 05753af:
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #172 by recognizing container projection and stereoscopic metadata according to FFmpeg specifications:
AV_SPHERICAL_EQUIRECTANGULAR_TILEwith 0.32 fixed-point boundaries, correctly mapping tiles whose horizontal bounds cover ~50% of the sphere (Google VR180 files) toVr180MonoorVr180Sbs, and unbounded tiles to full 360° Equirectangular.AV_SPHERICAL_FISHEYEtoFisheye190.AV_STEREO3D_FLAG_INVERTwith Side-by-Side toSideBySideRightand Top-Bottom toTopBottomRight.yaw,pitch,roll) fromAVSphericalMappingand carries it across the C ABI viaconsume_initial_orientation, rotating the initial scene view in both Vulkan and GLES renderers.Closes #172
Type of change
Affected layers
app/) — app shell, UI panels, credentials, history, i18nnative/) — OpenXR session, Vulkan/GLES render loop, controller inputrust/) — demux, decode, audio, network protocolsHow has this been tested?
cargo test): 58 tests inmedia-logic+ 251 tests in workspace passed../scripts/test-native-host.shand./scripts/check-shaders.shpassed).Checklist:
clippy -D warnings).If applicable
media-logic(host-testable) rather than incore, where it could not be tested.