Skip to content

Update of the BITalino sensors transfer functions (according to PLUX datasheets)#6

Closed
GRamosPlux wants to merge 2 commits intoBITalinoWorld:masterfrom
GRamosPlux:master
Closed

Update of the BITalino sensors transfer functions (according to PLUX datasheets)#6
GRamosPlux wants to merge 2 commits intoBITalinoWorld:masterfrom
GRamosPlux:master

Conversation

@GRamosPlux
Copy link

Dear @pires,
I truly hope that this message finds you well and facing exciting challenges in your projects!

During a support task involving the PLUX Support Team and a customer using this SDK, it was noticed that some sensor transfer functions were outdated.

Due to this circumstance, we decided to create this pull request (containing the updated transfer functions and unit tests) hoping that it can help the current and future members of your community!

My best and sincere regards,
GRamosPlux

@GRamosPlux GRamosPlux closed this Aug 26, 2021
@pires
Copy link
Contributor

pires commented Aug 26, 2021

Why was this closed only to be re-opened in #7? The commit hashes seem to be the same.

@GRamosPlux
Copy link
Author

Dear @pires,

I apologize for the mistake, you are totally correct, it was an unnecessary action.
This was the first time that I made a commit after the Pull Request and I thought that it wouldn't be included in #6 ':-D

My best and sincere regards,
@GRamosPlux

@pires
Copy link
Contributor

pires commented Aug 26, 2021

Totally fine, just wanted to understand. Thanks for clarifying.

@GRamosPlux
Copy link
Author

Dear @pires,

Thank you very much for your comprehension ;-)
Despite the undesirable mistake, this situation was really instructive to avoid similar actions in the future!

My best and sincere regards,
@GRamosPlux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants