Skip to content

[Review 131] fix: preserve macOS clipboard shortcuts in text fields - #1

Draft
BIackFIame wants to merge 3 commits into
codex/review-base-2026-10-07from
fix/macos-field-clipboard
Draft

BIackFIame wants to merge 3 commits into
codex/review-base-2026-10-07from
fix/macos-field-clipboard

Conversation

@BIackFIame

Copy link
Copy Markdown
Owner

Review purpose

Review-only copy of the prepared CanvasTTY series in the contributor's fork. This step covers: fix: preserve macOS clipboard shortcuts in text fields.

Related: howdeploy#131

The head is the exact upstream PR commit 22620f37238d4693c064216a5ba61fbc5fe7251d. The base is codex/review-base-2026-10-07 at 6faadcdc5e62aad689b0c042c4f180652e03230c. This matches the upstream PR comparison.

This PR is for review, not merging. Keep feedback attached to this exact commit. Source validation, live-test limitations and series context are recorded in the upstream PR; no new tests were run when creating this review copy.

@BIackFIame

Copy link
Copy Markdown
Owner Author

@codex review

Please review this PR's diff for correctness, regressions and security issues. Review only; post findings on GitHub without changing code.

This is the contributor-fork review for howdeploy#131, at the identical head commit 22620f37238d4693c064216a5ba61fbc5fe7251d. The PR base isolates this step of the series; use inherited code as context and focus findings on problems introduced by this diff. Include the concrete failure scenario and affected code in each actionable finding.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T20:55:09.012129Z b691ed7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22620f3723

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/index.ts Resolved
Comment thread src/main/editContextMenu.ts Resolved
@BIackFIame

Copy link
Copy Markdown
Owner Author

@codex review

Additional review round 1 of 5, head b691ed7a29f156e1ed50ea38462bd467ab47f93b. Review only; do not change code.

The previous findings are fixed and regression-tested: standalone plugin windows receive native edit menus before loading, and whitespace-only selections remain copyable. Please review the full PR diff again for correctness and regressions, especially focus/window ownership, editable fields, embedded plugin content and macOS shortcut behavior. Report concrete failure scenarios and avoid repeating resolved findings unless the fix is incomplete.

Local validation: 1803 tests passed, 3 skipped; typecheck, build and secrets audit passed. CI for this head is still running.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: b691ed7a29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BIackFIame

Copy link
Copy Markdown
Owner Author

@codex review

Additional review round 2 of 5, head b691ed7a29f156e1ed50ea38462bd467ab47f93b. Review only; do not change code.

The previous additional round completed without major issues. Review the full PR diff with a focus on window and renderer lifecycle, focus changes, nested plugin frames, event ordering and native clipboard shortcut dispatch. Look for concrete regressions or resource/event-handler problems; do not repeat already resolved findings unless the fix is incomplete. No code changes were made solely to request another pass.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: b691ed7a29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BIackFIame

Copy link
Copy Markdown
Owner Author

@codex review

Additional review round 3 of 5, head b691ed7a29f156e1ed50ea38462bd467ab47f93b. Review only; do not change code.

The first two additional rounds completed without major issues. Review the full PR diff focusing on security and trust boundaries: clipboard access from plugin frames/windows, editable-target detection, shortcut interception, navigation boundaries, and preserving restrictions in sandboxed content. Report concrete introduced defects, not hypothetical hardening or already resolved findings. No code changes were made solely to request another pass.

All three CI jobs passed on this head, including macOS and Windows checks.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: b691ed7a29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BIackFIame

Copy link
Copy Markdown
Owner Author

@codex review

Additional review round 4 of 5. Focus on compatibility and error handling: native edit menus in main and plugin windows, supported Electron context-menu parameters, empty and whitespace selections, window lifecycle, and existing behavior on other platforms. Review the current diff and report actionable bugs only. Please do not apply changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: b691ed7a29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BIackFIame

Copy link
Copy Markdown
Owner Author

@codex review

Additional review round 5 of 5. Final regression review of the current diff: verify that both original findings remain fixed, native edit menus work in main and plugin windows, whitespace selections remain copyable, tests meaningfully cover behavior, and no regressions were introduced. Report actionable defects only. Please do not apply changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: b691ed7a29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant